-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: structure of a AsyncAPI document #1922
docs: structure of a AsyncAPI document #1922
Conversation
✅ Deploy Preview for shimmering-choux-eb0798 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, @TRohit20! Left some suggestions that I believe can improve the quality of the document. Feel free to challenge them!
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to say thanks @TRohit20 for your valuable contribution to the docs 🙌
I left some comments, suggestions and change requests.
Additionally, I would like to recommend you to use a tool such as Grammarly to fix some minor typos and improve the grammar. I use it for documentation and works like a charm!
Co-authored-by: Sergio Moya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TW review left, hope it's exciting 😄😂✨
Hey @TRohit20, any update here? 🙂 |
Hey @jonaslagoni , Yes. Currently I am working on my initial draft for Request/Reply Document referring to the issue here. I will be done with the draft and raising a PR for the same in couple of days. Post which, I will be working on the weekend to make the required edits and modifications based on the suggestions provided for the document in this PR. I will have changes made and update the files soon. Thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alequetzalli ready for final review from your side
I decided to no longer make comments but make changes directly, feel free to revert anything you do not agree with -> b4e5b61
- I updated examples to be consistent and follow v3
- added more
you
so it is not as boring as spec document and targets reader - diagrams updates and naming + use
LR
style as they were hard to read when defaultTD
was used
/rtm |
Description
As part of Google Season of Docs 2023 at AsyncAPI, we're going to write in-depth explanations of the different sections of an AsyncAPI document to avoid difficulties in implementing EDAs.
For this document issue, we'll introduce the structure of a AsyncAPI document, why it is necessary and the root elements of it.
Related issue
This task is part of the GSoD Docs EPIC: #1508.
Resolves #1508