Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: structure of a AsyncAPI document #1922

Merged
merged 23 commits into from
Nov 16, 2023

Conversation

TRohit20
Copy link
Collaborator

@TRohit20 TRohit20 commented Jul 9, 2023

Description

As part of Google Season of Docs 2023 at AsyncAPI, we're going to write in-depth explanations of the different sections of an AsyncAPI document to avoid difficulties in implementing EDAs.

For this document issue, we'll introduce the structure of a AsyncAPI document, why it is necessary and the root elements of it.

Related issue
This task is part of the GSoD Docs EPIC: #1508.
Resolves #1508

Screenshot 2023-07-08 at 12 36 46 PM

@netlify
Copy link

netlify bot commented Jul 9, 2023

Deploy Preview for shimmering-choux-eb0798 ready!

Name Link
🔨 Latest commit c8ca885
🔍 Latest deploy log https://app.netlify.com/sites/shimmering-choux-eb0798/deploys/65557054294c41000885c280
😎 Deploy Preview https://deploy-preview-1922--shimmering-choux-eb0798.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TRohit20 TRohit20 marked this pull request as ready for review July 11, 2023 16:51
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, @TRohit20! Left some suggestions that I believe can improve the quality of the document. Feel free to challenge them!

pages/docs/concepts/asyncapi-document/structure.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/structure.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/structure.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/structure.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/structure.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/structure.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/structure.md Outdated Show resolved Hide resolved
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to say thanks @TRohit20 for your valuable contribution to the docs 🙌

I left some comments, suggestions and change requests.
Additionally, I would like to recommend you to use a tool such as Grammarly to fix some minor typos and improve the grammar. I use it for documentation and works like a charm!

pages/docs/concepts/asyncapi-document/structure.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/structure.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/structure.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/structure.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/structure.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/structure.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/structure.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/structure.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/structure.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/structure.md Outdated Show resolved Hide resolved
fmvilas
fmvilas previously approved these changes Jul 14, 2023
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@quetzalliwrites quetzalliwrites added 📑 docs area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. gsod This label should be used for issues or discussions related to ideas for Google Season of Docs labels Jul 20, 2023
Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TW review left, hope it's exciting 😄😂✨

@jonaslagoni
Copy link
Member

Hey @TRohit20, any update here? 🙂

@TRohit20
Copy link
Collaborator Author

Hey @jonaslagoni , Yes. Currently I am working on my initial draft for Request/Reply Document referring to the issue here. I will be done with the draft and raising a PR for the same in couple of days. Post which, I will be working on the weekend to make the required edits and modifications based on the suggestions provided for the document in this PR. I will have changes made and update the files soon. Thanks :)

derberg
derberg previously approved these changes Nov 15, 2023
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alequetzalli ready for final review from your side

I decided to no longer make comments but make changes directly, feel free to revert anything you do not agree with -> b4e5b61

  • I updated examples to be consistent and follow v3
  • added more you so it is not as boring as spec document and targets reader
  • diagrams updates and naming + use LR style as they were hard to read when default TD was used

@quetzalliwrites
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit ede5a28 into asyncapi:next-major-spec Nov 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. 📑 docs gsod This label should be used for issues or discussions related to ideas for Google Season of Docs ready-to-merge
Projects
Status: Community PR under Review 🧐
Development

Successfully merging this pull request may close these issues.

7 participants