fix: made the links width 100% #1955
Conversation
shubhamku044
requested review from
derberg,
akshatnema,
magicmatatjahu,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1955--asyncapi-website.netlify.app/ |
shubhamku044
changed the title
|
This PR targets to extend the link inside Docs Nav Tree items to full width. Earlier, whenever the user hovers to the text, then only the link becomes active, but with this PR, it creates a inline-bock around the text that gives the link functionality. @derberg are you good with the changes? |
|
@akshatnema better show some screenshots before and after and ask docs and design folks. I don't have a strong opinion |
|
@shubhamku044 can you please provide a demo video showing both websites and the changes? |
|
yes sure, sending you a video in few minutes |
Overview._.AsyncAPI.Initiative.for.event-driven.APIs.-.http_localhost_3000_docs_concepts.mp4 |
|
@derberg You can now see the difference between the first and the second preview of the sidebar. Links will be more accessible instead of restricting it's width to text only. First view - PR Changes Preview, Second view - AsyncAPI website |
|
/rtm |
Description
Earlier we have to move the cursor on the text to click any of the links. But now I made its width complete.
Related issue(s)
Fixes #1741