-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: tags in a AsyncAPI document #1957
docs: tags in a AsyncAPI document #1957
Conversation
✅ Deploy Preview for shimmering-choux-eb0798 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've given some reviews from my side. Please take a look and provide your feedback @TRohit20
# yaml-language-server: $schema=https://raw.githubusercontent.com/asyncapi/spec-json-schemas/next-major-spec/schemas/3.0.0-without-%24id.json
asyncapi: 3.0.0
components:
tags:
speech:
name: Speech
description: All speech related topics.
video:
name: Video
description: All video related topics.
info:
title: AsyncAPI Documentation
version: 1.0.0
description: |
This AsyncAPI document provides a overview
of the event-driven system.
tags:
- $ref: '#/components/tags/speech'
- $ref: '#/components/tags/audio'
servers:
speech:
host: localhost:5672
description: RabbitMQ broker for sendind speech data.
protocol: amqp
tags:
- $ref: '#/components/tags/speech'
video:
host: localhost:5673
description: RabbitMQ broker for audio information.
protocol: amqp
tags:
- $ref: '#/components/tags/video'
channels:
getSpeech:
address: 'application/speech/get'
servers:
- $ref: '#/servers/speech'
messages:
voice:
name: Voice
summary: Add info about the voice stream data.
tags:
- $ref: '#/components/tags/speech'
getVideo:
address: 'application/video/get'
servers:
- $ref: '#/servers/video'
messages:
voice:
name: Video
summary: Add info about the video data live bitrate and others.
tags:
- $ref: '#/components/tags/video'
operations:
onVoiceStreamed:
title: Get speech data
channel:
$ref: '#/channels/getSpeech'
action: receive
tags:
- $ref: '#/components/tags/speech'
onVideoStreamed:
title: Get video data
channel:
$ref: '#/channels/getVideo'
action: receive
tags:
- $ref: '#/components/tags/video' |
recording of feedback session about Tags between me and @TRohit20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TW review done 😄✨✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments
my biggest doubts are with the visualizations, like there is too much content.
there is a lot of additional information that do not bring value. And the biggest value we are missing from those is that they always explain tabs
object but do not mention Reference Object
my suggestion:
- if, like in case of
operation
you want to show fields other thantags
then my suggestion is to stick only to fields that are required. So foroperation
that would be onlyaddress
andchannel
+ you would addtag
. - if you want to keep visualization, you need to show
$ref
as alternative too, especially that they are really the core of new functionality and you anyway show them in the final example
I think you missed my comment about diagrams also please check links - they will not work on website as you link to markdown files. Another request, always before you submit for review, check your document in the preview on the website, so you see how content is rendered and if links work (you have browser plugins for links validation) hint - you folks in doc contributors group could come up with a cheat sheet for PR, like basic stuff to do before PR is ready for review (studio examples check, preview in website check for formatting, links validation). That would be super beneficial long term |
did you see my comment -> #1957 (comment) |
/rtm |
Description
As part of Google Season of Docs 2023 at AsyncAPI, we're going to write in-depth explanations of the different sections of an AsyncAPI document to avoid difficulties in implementing EDAs.
For this document issue, we'll be adding document about
tags
object in a AsyncAPI document and how it helps us organise the AsyncAPI documentRelated issue
This task is part of the GSoD Docs EPIC: #1507.
Resolves #1518