Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adding document for extending the AsyncAPI specification #1962

Closed
wants to merge 8 commits into from
Closed

docs: adding document for extending the AsyncAPI specification #1962

wants to merge 8 commits into from

Conversation

mhmohona
Copy link
Contributor

@mhmohona mhmohona commented Jul 18, 2023 •
edited
Loading

Description
Added Extending Specification page.

It is a part of GSoD'23 project.

Related issue(s):
fixes #1519

@netlify
Copy link

netlify bot commented Jul 18, 2023 •
edited
Loading

✅ Deploy Preview for shimmering-choux-eb0798 ready!

Name Link
🔨 Latest commit 3b3e546
🔍 Latest deploy log https://app.netlify.com/sites/shimmering-choux-eb0798/deploys/6528aa6f1323e10008922d64
😎 Deploy Preview https://deploy-preview-1962--shimmering-choux-eb0798.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mhmohona mhmohona changed the title adding new page docs: adding document for extending the AsyncAPI specification Jul 18, 2023
AnimeshKumar923
AnimeshKumar923 reviewed Jul 18, 2023
View reviewed changes
Copy link
Contributor

@AnimeshKumar923 AnimeshKumar923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look and provide your feedback @mhmohona

pages/docs/concepts/asyncapi-document/extending-specification.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/extending-specification.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/extending-specification.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/extending-specification.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/extending-specification.md Outdated Show resolved Hide resolved
quetzalliwrites
quetzalliwrites requested changes Jul 20, 2023
View reviewed changes
Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready for you to start the next draft! ✨✨✨

@quetzalliwrites quetzalliwrites added 📑 docs area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. gsod This label should be used for issues or discussions related to ideas for Google Season of Docs labels Jul 20, 2023
@mhmohona
Copy link
Contributor Author

Hello @jonaslagoni, thank you for your kind review!
I have updated the PR as per review. Will you please again have a look at it?

@quetzalliwrites
Copy link
Member

Let's focus on getting another round of detailed technical review from someone like Fran, @smoya or @derberg before I provide a detailed editorial review.

I see Fran left some feedback, please make sure you follow up with him if you feel confusion about what he suggests.

@quetzalliwrites
Copy link
Member

Really loving this first draft, lots of good work here to get started in the right direction ✨✨✨

derberg
derberg requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yo, left few suggestions

pages/docs/concepts/asyncapi-document/extending-specification.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/extending-specification.md Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/extending-specification.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/extending-specification.md Outdated Show resolved Hide resolved
pages/docs/concepts/asyncapi-document/extending-specification.md Outdated Show resolved Hide resolved
@mhmohona mhmohona requested a review from derberg October 13, 2023 02:20
@derberg derberg deleted the branch asyncapi:next-major-spec December 5, 2023 09:40
@derberg derberg closed this Dec 5, 2023
@mhmohona mhmohona mentioned this pull request Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quetzalliwrites quetzalliwrites quetzalliwrites requested changes

@AnimeshKumar923 AnimeshKumar923 AnimeshKumar923 left review comments

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve

@fmvilas fmvilas Awaiting requested review from fmvilas

@smoya smoya Awaiting requested review from smoya

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni

@derberg derberg Awaiting requested review from derberg

Assignees

@mhmohona mhmohona

Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. 📑 docs gsod This label should be used for issues or discussions related to ideas for Google Season of Docs
Projects
AsyncAPI Docs Board
Status: Community PR under Review 🧐
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mhmohona @quetzalliwrites @derberg @jonaslagoni @AnimeshKumar923