Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: removed @monaco-editor/react and @monaco-editor from package.json #1972

Closed
wants to merge 1 commit into from

Conversation

ThaungThanHan
Copy link
Contributor

@ThaungThanHan ThaungThanHan commented Jul 20, 2023

Description

Related issue(s)

@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 862f8cb
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/64b8a0424d8ef70008c1623c
😎 Deploy Preview https://deploy-preview-1972--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 60
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1972--asyncapi-website.netlify.app/

@ThaungThanHan ThaungThanHan changed the title Removed @monaco-editor/react and @monaco-editor from package.json chore!: Removed @monaco-editor/react and @monaco-editor from package.json Jul 20, 2023
@ThaungThanHan ThaungThanHan changed the title chore!: Removed @monaco-editor/react and @monaco-editor from package.json chore!: removed @monaco-editor/react and @monaco-editor from package.json Jul 20, 2023
@AnimeshKumar923
Copy link
Contributor

Description

Removed @monaco-editor/react and @monaco-editor from package.json

Related issue(s)

@ThaungThanHan Please edit and mention the issue that the PR addresses in the Related issue(s) section

Copy link

@HassanBahati HassanBahati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThaungThanHan did you run npm uninstall @monaco-editor/react monaco-editor ??

seems like you just deleted the 2 lines from the package.json meaning that the packages are still being tracked by the package-lock.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove @monaco-editor/react and @monaco-editor from package.json
3 participants