-
-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: hello world tutorial for AsyncApi v3 #2004
docs: hello world tutorial for AsyncApi v3 #2004
Conversation
✅ Deploy Preview for shimmering-choux-eb0798 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got a few comments 🙂
General comments:
- Does not seem like the syntax:
asyncapi
is rendered 🤔 - I would try not to use
subscribe
andpublish
unless the channels explicitly use an event broker, otherwise, I would keep the wording to the application receive or send something.
Co-authored-by: Jonas Lagoni <[email protected]>
hi @jonaslagoni this line i dont get which |
It's the ` characters, where you highlight certain words, is rendered exactly as ` instead of highlighting the word such as |
I used the style of previous Async Hello world tutorial v2, but I will remove it |
I pushed directory to @alaminthespecial branch to address missing parts. Thanks @alaminthespecial for initial hard work. @alequetzalli ready for final review |
/rtm |
Description
operations
section that i could not be able to phrase but i try here in the image bellow.Related issue(s)
fix #1857