-
-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add features list translations #2074
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,50 +1,39 @@ | ||
| export const features = [ | ||
| { | ||
| name: "Specification", | ||
| description: | ||
| "Allows you to define the interfaces of asynchronous APIs and is protocol agnostic.", | ||
| links: [{ label: "Documentation", href: "docs/specifications/latest", id:'whyasyncapi-spec-documentation-link' }], | ||
| }, | ||
| { | ||
| name: "Document APIs", | ||
| description: | ||
| "Use our tools to generate documentation at the build level, on a server, and on a client.", | ||
| links: [ | ||
| { | ||
| label: "HTML Template", | ||
| href: "https://github.com/asyncapi/html-template", | ||
| id:'whyasyncapi-apis-htmltemplate-link' | ||
| }, | ||
| { | ||
| label: "React Component", | ||
| href: "https://github.com/asyncapi/asyncapi-react/", | ||
| id:'whyasyncapi-apis-reactcomponents-link' | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| name: "Code Generation", | ||
| description: | ||
| "Generate documentation, Code (TypeScript, Java, C#, etc), and more out of your AsyncAPI files.", | ||
| links: [{ label: "Generator", href: "tools/generator", id:'whyasyncapi-generation-generator-link' }, { label: "Modelina", href: "tools/modelina", id:'whyasyncapi-generation-modelina-link' }], | ||
| }, | ||
| { | ||
| name: "Community", | ||
| description: "We're a community of great people who are passionate about AsyncAPI and event-driven architectures.", | ||
| links: [ | ||
| { label: "Join our Slack", href: "https://asyncapi.com/slack-invite", id:'whyasyncapi-community-slack-link' }, | ||
| ], | ||
| }, | ||
| { | ||
| name: "Open Governance", | ||
| description: | ||
| "Our Open-Source project is part of Linux Foundation and works under an Open Governance model.", | ||
| links: [{ label: "Read more about Open Governance", href: "blog/governance-motivation", id:'whyasyncapi-governance-more-link' }, { label: "TSC Members", href: "community/tsc", id:'whyasyncapi-governance-tsc-link' }], | ||
| }, | ||
| { | ||
| name: "And much more...", | ||
| description: | ||
| "We have many different tools and welcome you to explore our ideas and propose new ideas to AsyncAPI.", | ||
| links: [{ label: "View GitHub Discussions", href: "https://github.com/asyncapi/community/discussions", id:'whyasyncapi-muchmore-github-link' }], | ||
| }, | ||
| ]; | ||
| { | ||
| id: "specification", | ||
| links: [{ label: "Documentation", href: "docs/specifications/latest", id: 'whyasyncapi-spec-documentation-link' }], | ||
| }, | ||
| { | ||
| id: 'document-apis', | ||
| links: [ | ||
| { | ||
| label: "HTML Template", | ||
| href: "https://github.com/asyncapi/html-template", | ||
| id: 'whyasyncapi-apis-htmltemplate-link' | ||
| }, | ||
| { | ||
| label: "React Component", | ||
| href: "https://github.com/asyncapi/asyncapi-react/", | ||
| id: 'whyasyncapi-apis-reactcomponents-link' | ||
| }, | ||
| ], | ||
| }, | ||
| { | ||
| id: "code-generation", | ||
| links: [{ label: "Generator", href: "tools/generator", id: 'whyasyncapi-generation-generator-link' }, { label: "Modelina", href: "tools/modelina", id: 'whyasyncapi-generation-modelina-link' }], | ||
| }, | ||
| { | ||
| id: "community", | ||
| links: [ | ||
| { label: "Join our Slack", href: "https://asyncapi.com/slack-invite", id: 'whyasyncapi-community-slack-link' }, | ||
| ], | ||
| }, | ||
| { | ||
| id: "open-governance", | ||
| links: [{ label: "Read more about Open Governance", href: "blog/governance-motivation", id: 'whyasyncapi-governance-more-link' }, { label: "TSC Members", href: "community/tsc", id: 'whyasyncapi-governance-tsc-link' }], | ||
| }, | ||
| { | ||
| id: "much-more", | ||
| links: [{ label: "View GitHub Discussions", href: "https://github.com/asyncapi/community/discussions", id: 'whyasyncapi-muchmore-github-link' }], | ||
| }, | ||
| ]; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anshgoyalevil
Do we need that file when we have this content inside
locales? Except that question, everything is good :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Actually we are using the ids of those features to create unique translation keys to fetch those from the locales. It would also act like a first source of truth, and cypress testing, since parsing from the json would not be convenient in cypress tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like here for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So maybe put another texts as values to keys, not whole content, ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't get that. Please clarify. Do you mean creating another array of keys inside the file itself rather than importing features.js and using it for keys?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you did :) Only remove not needed keys from
/featuresmap, likedescriptionetc, only leave id, label, href etc, what you exactly used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with the changes 🚀