-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add translations for tools/cli page #2078
Conversation
Signed-off-by: Ansh Goyal <[email protected]>
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2078--asyncapi-website.netlify.app/ |
Signed-off-by: Ansh Goyal <[email protected]>
//cc @magicmatatjahu 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/rtm |
Description
tools/cli.js
is moved to[lang]/tools/cli.js
folder so that i18n could render the translation.pages/tools/cli.js
file would be removed and onlypages/[lang]/tools/cli.js
file would be kept, enabling the translations for all users.Related issue(s)
part of: #2039
How to view the translated page