Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add translations for tools/cli page #2078

Merged
merged 8 commits into from
Sep 1, 2023

Conversation

anshgoyalevil
Copy link
Member

@anshgoyalevil anshgoyalevil commented Aug 20, 2023

Description

  • This PR adds the translation for the tools/cli page.
  • The tools/cli.js is moved to [lang]/tools/cli.js folder so that i18n could render the translation.
  • In the last PR, the pages/tools/cli.js file would be removed and only pages/[lang]/tools/cli.js file would be kept, enabling the translations for all users.
  • In the meantime, these two pages are maintained for end users.

Related issue(s)

part of: #2039

How to view the translated page

@netlify
Copy link

netlify bot commented Aug 20, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 96c70c5
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/64f1cf15c00a980008091cde
😎 Deploy Preview https://deploy-preview-2078--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Aug 20, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 24
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-2078--asyncapi-website.netlify.app/

@anshgoyalevil
Copy link
Member Author

//cc @magicmatatjahu 🚀

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@magicmatatjahu
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit a5226d7 into asyncapi:master Sep 1, 2023
19 checks passed
@anshgoyalevil anshgoyalevil deleted the tools1 branch September 8, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants