Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add global eslint plugin #2288

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

anshgoyalevil
Copy link
Member

Description

  • This PR adds a global eslint plugin that can act as a single source of configuration for all other repositories, that use eslint.
  • Further plugin documentation can be found at: https://github.com/anshgoyalevil/eslint-config
  • If everything's alright on the implementation side, we can go ahead and move the plugin repository to AsyncAPI organization, and republish it to npm under the @asyncapi organization handle.

Related issue(s)

fixes: #1946

Signed-off-by: Ansh Goyal <[email protected]>
Copy link

netlify bot commented Nov 3, 2023

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit eccc250
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/65493be5ffb2db00087a86b5
😎 Deploy Preview https://deploy-preview-2288--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @anshgoyalevil 👋 ,
I'm really impressed by the PR and changes you made for eslint plugin. Basically, the eslint plugin you created is awesome. I approve on my side, but let's wait for @derberg review as well.

@anshgoyalevil
Copy link
Member Author

Thanks @akshatnema 🚀😄

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done 👏🏼

@asyncapi-bot
Copy link
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 32
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-2288--asyncapi-website.netlify.app/

@derberg
Copy link
Member

derberg commented Nov 6, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 40bc38d into asyncapi:master Nov 6, 2023
19 checks passed
@anshgoyalevil anshgoyalevil deleted the add-es branch February 24, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add custom eslint plugin for organization repositories
4 participants