Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: re-add Coming from OpenAPI #2307

Merged
merged 5 commits into from
Nov 14, 2023
Merged

docs: re-add Coming from OpenAPI #2307

merged 5 commits into from
Nov 14, 2023

Conversation

derberg
Copy link
Member

@derberg derberg commented Nov 9, 2023

resolves #1856

adding https://www.asyncapi.com/docs/tutorials/getting-started/coming-from-openapi to v3

The only document that I think can talk about AsyncAPI 2.0 as it makes sense to have official document that talks about AsyncAPI evolution.

@netlify Netlify
Copy link

netlify bot commented Nov 9, 2023 •
edited
Loading

✅ Deploy Preview for shimmering-choux-eb0798 ready!

Name Link
🔨 Latest commit 0ea2b42
🔍 Latest deploy log https://app.netlify.com/sites/shimmering-choux-eb0798/deploys/6552098715bcc600082e1329
😎 Deploy Preview https://deploy-preview-2307--shimmering-choux-eb0798.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@quetzalliwrites
Copy link
Member

quetzalliwrites commented Nov 11, 2023 •
edited
Loading

You made some JS changes, so you also need a JS code owner such as Akshat Nema to approve to merge 😄.

(inspired to give me JS maintainer access yet? 😂) @derberg

cc SOS @akshatnema for this one too 📢😅

akshatnema
akshatnema requested changes Nov 11, 2023
View reviewed changes
Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @derberg, I see some errors in the preview of the PR.

image

These fields are colored by default.

image

Also, I see Parameters field not getting compared in this component.

@derberg
Copy link
Member Author

derberg commented Nov 13, 2023

These fields are colored by default.

yes, it was intentional, it is like this in https://www.asyncapi.com/docs/tutorials/getting-started/coming-from-openapi (some props set to true by default). But anyway, I did some errors in colouring, now it is perfected 😄

Also, I see Parameters field not getting compared in this component.

not compared like others, only entire components is. Why do you think it ain't right?

@akshatnema
Copy link
Member

not compared like others, only entire components is. Why do you think it ain't right?

I thought both are same 😅

@derberg
Copy link
Member Author

derberg commented Nov 14, 2023

/rtm

@derberg
Copy link
Member Author

derberg commented Nov 14, 2023

@alequetzalli you can approve again

@quetzalliwrites
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit dfebdde into asyncapi:next-major-spec Nov 14, 2023
12 checks passed
@derberg derberg mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quetzalliwrites quetzalliwrites quetzalliwrites approved these changes

@akshatnema akshatnema akshatnema approved these changes

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve

@mcturco mcturco Awaiting requested review from mcturco

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@derberg @quetzalliwrites @akshatnema @asyncapi-bot