Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: migrate code generation and message validation tutorials to use Glee #2317

Merged

Conversation

fmvilas
Copy link
Member

@fmvilas fmvilas commented Nov 14, 2023

Description
This tutorial uses Glee instead of the code generator now. It simplifies getting started with it.

TODO:

  • Check that every step that's needed is thoroughly documented. So far, updating the .env file is missing and it must be there.
  • Ideally, we should wait on this issue. This would simplify the tutorial by a lot, making the above point unimportant.

Related issue(s)
asyncapi/cli#887

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for shimmering-choux-eb0798 ready!

Name Link
🔨 Latest commit 8aecd6a
🔍 Latest deploy log https://app.netlify.com/sites/shimmering-choux-eb0798/deploys/6567808a40a3c50008c96c1f
😎 Deploy Preview https://deploy-preview-2317--shimmering-choux-eb0798.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fmvilas fmvilas marked this pull request as ready for review November 21, 2023 11:09
@fmvilas fmvilas requested a review from derberg November 21, 2023 11:10
pages/docs/tutorials/generate-code.md Outdated Show resolved Hide resolved
pages/docs/tutorials/generate-code.md Show resolved Hide resolved
pages/docs/tutorials/generate-code.md Outdated Show resolved Hide resolved
pages/docs/tutorials/generate-code.md Outdated Show resolved Hide resolved
pages/docs/tutorials/generate-code.md Show resolved Hide resolved
pages/docs/tutorials/message-validation.md Outdated Show resolved Hide resolved
pages/docs/tutorials/message-validation.md Show resolved Hide resolved
pages/docs/tutorials/message-validation.md Show resolved Hide resolved
pages/docs/tutorials/message-validation.md Outdated Show resolved Hide resolved
pages/docs/tutorials/message-validation.md Outdated Show resolved Hide resolved
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmvilas probably one of my code changes suggestion breaks the build, I bet on CodeBlock usage. You will have to investigate locally I think

@fmvilas
Copy link
Member Author

fmvilas commented Nov 26, 2023

@derberg problems fixed.

derberg
derberg previously approved these changes Nov 28, 2023
@quetzalliwrites
Copy link
Member

I already added a commit to fix grammar issues, but I have two pending questions I need Fran's reply to before I can click approve 😸

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹 :shipit:

@quetzalliwrites
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit cdd2e02 into asyncapi:next-major-spec Nov 29, 2023
10 checks passed
@fmvilas fmvilas deleted the migrate-code-generation-tutorials branch November 29, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants