Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: revert adding document for servers' security #2323

Closed

Conversation

quetzalliwrites
Copy link
Member

Reverts #2231

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for shimmering-choux-eb0798 ready!

Name Link
🔨 Latest commit dfeedae
🔍 Latest deploy log https://app.netlify.com/sites/shimmering-choux-eb0798/deploys/65558cd37d194d000864bf94
😎 Deploy Preview https://deploy-preview-2323--shimmering-choux-eb0798.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@TRohit20 TRohit20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting the merge as the commit suggestions weren't actually committed I suppose? @alequetzalli

@quetzalliwrites quetzalliwrites changed the title Revert "docs: adding document for servers' security" docs: revert adding document for servers' security Nov 16, 2023
@quetzalliwrites
Copy link
Member Author

Reverting the merge as the commit suggestions weren't actually committed I suppose? @alequetzalli

Yeah, I made a mistake and still unsure best how to fix it LOL.

Essentially I thought I had committed in a single batch all my commit suggestions but then it turned out I hadn't yet, so IOW I merged the PR early.

Do you know how I should fix it? if you have a better process please share 😄😅

@quetzalliwrites
Copy link
Member Author

Just figured it out, closing this PR since I will open a new PR to edit the file instead.

@derberg derberg deleted the revert-2231-server-security-#1715 branch November 30, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants