Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: using AsyncAPI with Kafka using Avro #2329

Merged
merged 26 commits into from
Feb 10, 2024
Merged

Conversation

J0SAL
Copy link
Collaborator

@J0SAL J0SAL commented Nov 17, 2023

Description

  • Initial draft for configuring AsyncAPI document for an app interacting with Kafka messages using Avro Schemas

Related issue(s)

Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b548cf4
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/65c6cdffb12f7e00083f9048
😎 Deploy Preview https://deploy-preview-2329--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@J0SAL J0SAL changed the title doc: using AsyncAPI with Kafka using Avro docs: using AsyncAPI with Kafka using Avro Nov 17, 2023
@J0SAL J0SAL marked this pull request as ready for review December 15, 2023 05:29
@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Dec 15, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 46
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-2329--asyncapi-website.netlify.app/

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some suggestions

cool stuff btw ❤️

pages/docs/tutorials/kafka/index.md Outdated Show resolved Hide resolved
pages/docs/tutorials/kafka/configure-kafka-avro.md Outdated Show resolved Hide resolved
pages/docs/tutorials/kafka/configure-kafka-avro.md Outdated Show resolved Hide resolved
pages/docs/tutorials/kafka/configure-kafka-avro.md Outdated Show resolved Hide resolved
pages/docs/tutorials/kafka/configure-kafka-avro.md Outdated Show resolved Hide resolved
@J0SAL J0SAL requested a review from derberg December 27, 2023 13:59
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment

also remember that we should not merge with links like ttps://deploy-preview-2252--asyncapi-website.netlify.app/docs/tutorials/kafka so probably the other tutorial needs to be merged first and then you can update this PR with proper relative link to document

pages/docs/tutorials/kafka/configure-kafka-avro.md Outdated Show resolved Hide resolved
pages/docs/tutorials/kafka/_section.md Outdated Show resolved Hide resolved
pages/docs/tutorials/kafka/index.md Outdated Show resolved Hide resolved
pages/docs/tutorials/kafka/configure-kafka-avro.md Outdated Show resolved Hide resolved
pages/docs/tutorials/kafka/configure-kafka-avro.md Outdated Show resolved Hide resolved
pages/docs/tutorials/kafka/configure-kafka-avro.md Outdated Show resolved Hide resolved
@quetzalliwrites
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 3230389 into asyncapi:master Feb 10, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants