-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the NYC code coverage #2354
feat: add the NYC code coverage #2354
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2354--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the intrumented
, coverage
folder should be part of .gitignore
. And I also see that you forgot to run node scripts/index.js
command before copying the config folder. Add it inside script.
Also, you need to copy following files from the root to the instrumented
folder:
dashboard.json
scripts/tools/tools-schema.json
Also, do find out if any other files are missing inside instrumented folder and copy it from the root directory.
run: npx nyc instrument ./ instrumented | ||
|
||
- name: Move folder | ||
run: mv config instrumented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use cp
command instead of mv
. Also, move the entire folder using the command:
cp -r config instrumented/config
run: mv config instrumented | ||
|
||
- name: Run tests with coverage | ||
run: npm run test:coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of running the separate command/workflow for test coverage, can't we merge it with cypress-tests.yml
workflow?
Description
Related issue(s)
#2104