-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add payload #2414
docs: add payload #2414
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2414--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alequetzalli I rewrote completely as there were many generic parts, so instead of talking about complex schemas (completely different document, about JSON schema allOf, anyOf, oneOf and many others) I rewrote it to talk about payload
and how it is different now in v3, its tuple nature, schema formats and stuff
Go it, sorry to hear you had to completely rewrite and we weren't able to use the writer's work for this doc. Thank you for going the extra mile and completely rewriting some of the docs ❤️, appreciate you! @derberg |
@kakabisht I would love to have you comment back on this PR and detail what you thought this doc was supposed to cover or where the confusion was, so we can identify how to improve instructions next year with writers 😸 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm proud of our work on this one, @derberg 😃
/rtm |
This document covers:
Refer: #1515