Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add Variables in URL #2415

Merged
merged 4 commits into from
Dec 12, 2023
Merged

docs: add Variables in URL #2415

merged 4 commits into from
Dec 12, 2023

Conversation

kakabisht
Copy link
Contributor

This document covers:

  • Define server section
  • Define components server.Variables section
  • Define domain and port variables

Refer: #1509

@netlify Netlify
Copy link

netlify bot commented Dec 9, 2023 •
edited
Loading

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cba46e0
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/65788f9fd59f050009c304e2
😎 Deploy Preview https://deploy-preview-2415--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Dec 9, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 45
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-2415--asyncapi-website.netlify.app/

@kakabisht kakabisht changed the title docs: Add Variables in URL docs: add Variables in URL Dec 9, 2023
derberg
derberg reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alequetzalli I changed a lot, including diagram

basically url field is no longer there, it is host and pathname

you can merge once you review

@quetzalliwrites
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 945d6c6 into asyncapi:master Dec 12, 2023
19 checks passed
@TRohit20 TRohit20 mentioned this pull request Mar 5, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg left review comments

@quetzalliwrites quetzalliwrites quetzalliwrites approved these changes

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kakabisht @asyncapi-bot @quetzalliwrites @derberg