Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixing docs bugs made by quetzalli #2644

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

quetzalliwrites
Copy link
Member

@quetzalliwrites quetzalliwrites commented Feb 10, 2024

I just realized I accidentally merged a couple of mistakes to docs, so fixing them 🥲

The Kafka section is in the wrong order in the nav (should be after new WebSocket section) and there is a period in one of the WebSocket page titles.

Screenshot 2024-02-13 at 6 05 04 PM

@quetzalliwrites quetzalliwrites added 🐞 docs bug area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. labels Feb 10, 2024
@quetzalliwrites quetzalliwrites self-assigned this Feb 10, 2024
Copy link

netlify bot commented Feb 10, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 654948d
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/65cc78c9a7eb140008935be3
😎 Deploy Preview https://deploy-preview-2644--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Feb 10, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 39
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-2644--asyncapi-website.netlify.app/

@quetzalliwrites
Copy link
Member Author

@thulieblack or @akshatnema, can you please review the new correct order via the preview link and help approve this PR? Our new Kafka section is in the wrong place in our docs navigation, creating a confusing user experience. 😿

@akshatnema
Copy link
Member

image

@alequetzalli is this the right position for Kafka directory? I see this in the preview.

@thulieblack
Copy link
Member

Based on the PR description, it is Akshat; it's supposed to be below the WebSocket.

@thulieblack
Copy link
Member

/rtm

@thulieblack
Copy link
Member

damn I forgot, please @akshatnema do approve and merge please

@akshatnema akshatnema merged commit ac86bc3 into asyncapi:master Feb 14, 2024
19 checks passed
Copy link
Member Author

thank you so much for helping out, @thulieblack! 🍻 appreciate you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. 🐞 docs bug ready-to-merge
Projects
Status: Community PR under Review 🧐
Development

Successfully merging this pull request may close these issues.

5 participants