-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add workflow to notify docs triagers on relevant PRs #2660
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2660--asyncapi-website.netlify.app/ |
thank you for this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment made by the bot after workflow run, shouldn't be hard-coded, instead it should take the values from a json file or array that contains all the respective triager maintianers.
Everything seems to be working except the fact that we do not have write permissions allowed for GH Actions in this repo @derberg I am not sure how AsyncAPI bot comments on PRs using this workflow https://github.com/asyncapi/website/blob/master/.github/workflows/lint-pr-title.yml when we don't have write permissions for GH Actions. Do we need to add this workflow to // cc @akshatnema |
@akshatnema Fixed. @sambhavgupta0705 The workflow is currently under What do you think @derberg |
https://github.com/asyncapi/website/blob/master/.github/workflows/help-command.yml#L45-L60 @TRohit20 Can you try this approach to make a comment in PR? |
Hello, @akshatnema! 👋🏼
|
Will this work on issues also because I need to triage issues also |
@sambhavgupta0705 Sure, I mean we'd probably have to add another check and event trigger to see and make it work on issues too. Possible |
@TRohit20 is this ready for review? |
@sambhavgupta0705 As mentioned above, the secret needs PR comment/write access to make a comment as intended, the other workflow suggested to try by @akshatnema also didn't quite seem to work. |
Hmm @akshatnema would a short call help? |
Yeah, it needs to be added there, as far as I believe. |
@Shurtu-gal The GitHub script being used in latest commit is actually a reuse of what we currently have in one of our workflows as suggested by @akshatnema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All parts are working great (ref). LGTM 🚀
/rtm |
Description
The PR introduces a new workflow to the website repo which runs every time a new PR is raised and checks if any
.md
files were modified in any manner, if yes, the workflow will auto-comment tagging docs-triagers for review and approval.Related issue(s)
Resolves #2634
PS: Ofc, we would have to configure the secret(GH_Token) first to make this work.