Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add eslint configuration and netlify functions #2670

Merged
merged 13 commits into from
Feb 20, 2024

Conversation

akshatnema
Copy link
Member

@akshatnema akshatnema commented Feb 18, 2024

Description

  • Add new eslint configuration with all necessary plugins for typescript.
  • Add Netlify functions that need to be migrated to Typescript later on.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep it in JS only?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will later move it to typescript.

Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit eb07635
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/65d42b1301768900093cec5a
😎 Deploy Preview https://deploy-preview-2670--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anshgoyalevil
Copy link
Member

npm run start is failing locally, though the build is working fine.

> next start

   ▲ Next.js 14.1.0
   - Local:        http://localhost:3000

Error: "next start" does not work with "output: export" configuration. Use "npx serve@latest out" instead.

Rest, everything seems good 🚀

@anshgoyalevil anshgoyalevil merged commit 3cac6a7 into asyncapi:migrate-ts Feb 20, 2024
9 checks passed
@akshatnema akshatnema deleted the setup-next branch October 11, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants