Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate buttons folder #2672

Merged
merged 25 commits into from
Feb 29, 2024

Conversation

Shurtu-gal
Copy link
Contributor

Description

  • Migration of Buttons folder to TS.

Related issue(s)
#2636

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert icons in tsx as well.

@Shurtu-gal
Copy link
Contributor Author

Convert icons in tsx as well.

Okay

@Shurtu-gal Shurtu-gal marked this pull request as ready for review February 19, 2024 08:53
@Shurtu-gal
Copy link
Contributor Author

@akshatnema The PR is ready now.

Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3bda3a2
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/65df0f5e91d86d0008f8be50
😎 Deploy Preview https://deploy-preview-2672--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Shurtu-gal, PR looks good to me. I think the major missing part is regarding the comments only. Run npm run lint inside the PR and resolve the errors/warnings you are getting in changes made.

components/buttons/Button.tsx Outdated Show resolved Hide resolved
components/buttons/Button.tsx Show resolved Hide resolved
Copy link
Member

@sambhavgupta0705 sambhavgupta0705 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shurtu-gal please remove ApplyJobs.tsx ,openInPlayground.tsx and job.ts file

@Shurtu-gal
Copy link
Contributor Author

Screenshot as discussed in meet
image

types/post.ts Outdated Show resolved Hide resolved
@Shurtu-gal
Copy link
Contributor Author

@akshatnema everything works now.

@akshatnema
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit b2d9496 into asyncapi:migrate-ts Feb 29, 2024
13 checks passed
@Shurtu-gal Shurtu-gal deleted the feat/migrate-buttons branch February 29, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants