-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate buttons folder #2672
feat: migrate buttons folder #2672
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Convert icons in tsx as well.
Okay |
@akshatnema The PR is ready now. |
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Shurtu-gal, PR looks good to me. I think the major missing part is regarding the comments only. Run npm run lint
inside the PR and resolve the errors/warnings you are getting in changes made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shurtu-gal please remove ApplyJobs.tsx ,openInPlayground.tsx and job.ts file
@akshatnema everything works now. |
/rtm |
Description
Related issue(s)
#2636