Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added translation for testimonial data of Homepage #2724

Closed
wants to merge 4 commits into from

Conversation

PR4NJ41
Copy link

@PR4NJ41 PR4NJ41 commented Mar 2, 2024

Description

  • The testimonial data of Homepage was not getting translated earlier.
  • I have added the translation text to respective landing-page.json files for both the languages.
  • Instead of directly using the text I have fetched the text from .json files for the testimonial section.

Related issue(s)
Resolves Issue #2039

Before
Screenshot from 2024-03-03 03-03-20
Screenshot from 2024-03-03 03-03-36

After
Screenshot from 2024-03-03 02-46-38
Screenshot from 2024-03-03 02-47-05

Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d3e1d8d
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/65e754dac8cb6e0008e0a311
😎 Deploy Preview https://deploy-preview-2724--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Mar 2, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 30
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-2724--asyncapi-website.netlify.app/

@PR4NJ41 PR4NJ41 changed the title Added Translation For Testimonial data of Homepage fix: Added Translation For Testimonial data of Homepage Mar 2, 2024
@PR4NJ41 PR4NJ41 changed the title fix: Added Translation For Testimonial data of Homepage fix: added translation for testimonial data of Homepage Mar 2, 2024
@anshgoyalevil
Copy link
Member

Keeping testimonials in the English language was intentional as people give feedback about a product in their native language and expressions. If we translate that thing, it would feel like the testimonials are just another marketing piece that is dubbed into each language irrespective of the original text.

wdyt @derberg, @akshatnema ?

Copy link

github-actions bot commented Jul 4, 2024

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jul 4, 2024
@sambhavgupta0705
Copy link
Member

closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants