fix: updated docTriagers and triager workflow #2806
Conversation
akshatnema
requested review from
derberg,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2806--asyncapi-website.netlify.app/ |
.github/workflows/notify-triager.yml
Outdated
| @@ -6,6 +6,7 @@ on: | |||
|
|
|||
| jobs: | |||
| Notify-triagers: | |||
| if: ! contains(github.event.pull_request.head.sha, 'Merge branch') | |||
There was a problem hiding this comment.
This line is for skipping the workflow when the PR is updated. Am I correct?
If that's the case, .sha would give the unique commit hash, and not the actual message that contains Merge branch.
ref: https://github.com/orgs/community/discussions/28474#discussioncomment-3334578
.github/workflows/notify-triager.yml
Outdated
| echo "Last commit is a merge commit" | ||
| echo "skip" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
How would this condition enforce the remaining steps to be skipped?
|
/rtm |
Description
This PR updated the
docTriagersinside CODEOWNERS file and also updatednotify-triagerworkflow.