fix: i18n for smaller screen #3113
Conversation
TenzDelek
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3113--asyncapi-website.netlify.app/ |
|
Can we something like kubevela.io ?? |
sure, will try to do that !! |
|
@sambhavgupta0705 do the repo has a specific command for linting. the pr seems to be failing due to it. what might be the cause of it. am i missing a step. wouldn't it be better to have a precommit hook for lint staged when we do the commit 🤔 happens same at PR |
|
Can we change the icon in side of language to anything in deutsche |
|
And increase the right margin of en and de also in the drop-down |
|
Yes this only |
Lint cheeck passed in that PR ,there is a check fail which is because of change in npm and node version .We need to resolve it @akshatnema has more idea about it |
|
|
sure , will wait for the response from his side.. |
currently it is set to text-base, should we go with sm or xs |
For smaller screen yes and |
|
@Mayaleeeee Can you please take a look at this |
|
/update |
Hello @TenzDelek @sambhavgupta0705, Instead of using codes like 'en' and 'de', let's use terms people are more familiar with, such as 'English' and 'Deutsch', for a more user-friendly experience and to reach a broader audience. P.S. The position looks good on both the web and mobile. Is there anything else you'd like me to review on this issue? cc @TenzDelek @sambhavgupta0705 |
|
@TenzDelek push a review with these changes then we can look at this |
asyncapi-bot
requested review from
BhaswatiRoy,
J0SAL,
TRohit20 and
VaishnaviNandakumar
@sambhavgupta0705 check it once. have made some adjustment to the space x due to layout shift in the nav after the long form addition |
|
@TenzDelek I liked the design but we have a setup of using |
You mean the params? Didn't quite get you🤔 |
|
yes the params only A good approach will be to change the params from de to deutsch and en to english |
|
@TenzDelek any update? |
was bit busy past few days ! will look into this today or tomorrow |
can you help me with that a little bit.. what exactly we need to perform here. little bit confuse here. is it only changing file name here or ? |
Fixes #2708
As per mentioned by @anshgoyalevil Discuss, have put the i8n in the dropdown.