Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add scrollable Community dropdown to display all content #3553

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
+1 −1
Open

fix: add scrollable Community dropdown to display all content #3553

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2710835
Add scrollable Community dropdown to display all content
rahulrana701 Jan 7, 2025
a706c39
Merge branch 'master' into fix/community-dropdown-scroll
asyncapi-bot Jan 7, 2025
2fdfa1f
fixed
rahulrana701 Jan 7, 2025
dff3ed6
eslint fixed
rahulrana701 Jan 7, 2025
9e0b413
css fixed
rahulrana701 Jan 10, 2025
58d41d8
lint fixed
rahulrana701 Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/navigation/FlyoutMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default function Flyout({ items = [] }: FlyoutProps) {
>
<div className='rounded-lg shadow-lg'>
<div className='shadow-xs overflow-hidden rounded-lg'>
<div className='relative z-20 grid gap-6 bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2'>
<div className='scrollbar-thin scrollbar-thumb-gray-400 scrollbar-track-transparent relative z-20 grid max-h-96 min-h-40 gap-6 overflow-y-auto bg-white px-5 py-6 sm:gap-8 sm:p-8 lg:grid-cols-2'>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you limiting the maximum height of the dropdown? It should go as much as the screen size allows, and then the scrollbar for overflow content can be displayed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this change for a better UI experience, but I’ll fix it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anshgoyalevil done as suggested

<MenuBlocks items={items} />
</div>
</div>
Expand Down
Loading