fixed the logo in sponsors #3565
Conversation
dewang002
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe pull request focuses on modifying the Changes
Assessment against linked issues
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
We require all PRs to follow Conventional Commits specification. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3565 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 668 668
=========================================
Hits 668 668 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
components/sponsors/SponsorsList.ts (1)
9-23: Consider extracting common sponsor image styles.The current implementation duplicates height classes across multiple sponsors. Consider creating reusable Tailwind classes or using @apply to define sponsor image sizes. This would improve maintainability and ensure consistency across all sponsor components.
Example approach:
/* styles/sponsors.css */ .sponsor-image-sm { @apply inline-block px-4 h-12 sm:h-12; } .sponsor-image-md { @apply inline-block px-4 h-14 sm:h-14; }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
components/sponsors/GoldSponsorsList.ts(1 hunks)components/sponsors/SilverSponsorsList.ts(2 hunks)components/sponsors/SponsorsList.ts(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- components/sponsors/GoldSponsorsList.ts
- components/sponsors/SilverSponsorsList.ts
⏰ Context from checks skipped due to timeout of 180000ms (4)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Lighthouse CI
🔇 Additional comments (2)
components/sponsors/SponsorsList.ts (2)
9-9: LGTM! Consistent height across breakpoints.The addition of the default height class ensures consistent logo sizing, preventing layout shifts during page load.
16-16: LGTM! Maintains consistent pattern.The change follows the established pattern of setting default heights matching the responsive breakpoint heights.
| }, | ||
| { | ||
| name: 'Postman', | ||
| website: 'https://www.postman.com', | ||
| imageSrc: '/img/sponsors/postman.png', | ||
| altText: 'Postman', | ||
| imageClass: 'inline-block px-4 sm:h-18' | ||
| imageClass: 'inline-block px-4 h-18 sm:h-18' |
There was a problem hiding this comment.
💡 Codebase verification
Use h-72 instead of h-18 for 18rem height
The h-18 class is not defined in your Tailwind configuration. To achieve a height of 18rem, use h-72 which is properly configured in your tailwind.config.ts:
height: {
72: '18rem',
// ...
}🔗 Analysis chain
Verify the custom height class.
The h-18 class is not a standard Tailwind CSS class. Please verify if this is defined in your Tailwind configuration.
Let's check the Tailwind configuration:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for custom height configuration in Tailwind config files
fd -e js -e ts -e json "tailwind" | xargs rg -l "height|spacing.*18"
Length of output: 87
Script:
#!/bin/bash
# View the contents of tailwind.config.ts
cat tailwind.config.ts
Length of output: 5771
Description
over here I just fix the size of logo in sponsore section.
before it look like this
after it look like this
Related issue(s)
Fixes #3158Summary by CodeRabbit
imageClassproperties to adjust height classes for responsive design