style: reduce warnings

cluster/config.go

@@ -98,8 +98,6 @@ func withClusterReceiveMiddleware() actor.PropsOption {
 			default:
 				next(c, envelope)
 			}
-
-			return
 		}
 	})
 }

cluster/consensus_check_builder.go

@@ -3,6 +3,7 @@
 package cluster
 
 import (
+	"context"
 	"fmt"
 	"log/slog"
 	"strings"
@@ -132,23 +133,19 @@ func (ccb *ConsensusCheckBuilder) build() func(*GossipState, map[string]empty) (
 	}
 
 	showLog := func(hasConsensus bool, topologyHash uint64, valueTuples []*consensusMemberValue) {
-		if ccb.logger.Enabled(nil, slog.LevelDebug) {
+		if ccb.logger.Enabled(context.Background(), slog.LevelDebug) {
 			groups := map[string]int{}
 			for _, memberValue := range valueTuples {
 				key := fmt.Sprintf("%s:%d", memberValue.key, memberValue.value)
-				if _, ok := groups[key]; ok {
-					groups[key]++
-				} else {
-					groups[key] = 1
-				}
+				groups[key]++
 			}
 
 			for k, value := range groups {
 				suffix := strings.Split(k, ":")[0]
 				if value > 1 {
 					suffix = fmt.Sprintf("%s, %d nodes", k, value)
 				}
-				ccb.logger.Debug("consensus", slog.Bool("consensus", hasConsensus), slog.String("values", suffix))
+				ccb.logger.Debug("consensus", slog.Bool("consensus", hasConsensus), slog.String("values", suffix), slog.Uint64("topologyHash", topologyHash))
 			}
 		}
 	}
@@ -157,7 +154,7 @@ func (ccb *ConsensusCheckBuilder) build() func(*GossipState, map[string]empty) (
 		mapToValue := ccb.MapToValue(ccb.getConsensusValues[0])
 
 		return func(state *GossipState, ids map[string]empty) (bool, interface{}) {
-			var memberStates []map[string]*GossipMemberState
+			memberStates := []map[string]*GossipMemberState{}
 			getValidMemberStates(state, ids, memberStates)
 
 			if len(memberStates) < len(ids) { // Not all members have state...
@@ -180,7 +177,7 @@ func (ccb *ConsensusCheckBuilder) build() func(*GossipState, map[string]empty) (
 	}
 
 	return func(state *GossipState, ids map[string]empty) (bool, interface{}) {
-		var memberStates []map[string]*GossipMemberState
+		memberStates := []map[string]*GossipMemberState{}
 		getValidMemberStates(state, ids, memberStates)
 
 		if len(memberStates) < len(ids) { // Not all members have state...

cluster/gossip_actor.go

@@ -25,7 +25,6 @@ type GossipActor struct {
 
 // Creates a new GossipActor and returns a pointer to its location in the heap
 func NewGossipActor(requestTimeout time.Duration, myID string, getBlockedMembers func() set.Set[string], fanOut int, maxSend int, system *actor.ActorSystem) *GossipActor {
-
 	logger := system.Logger()
 	informer := newInformer(myID, getBlockedMembers, fanOut, maxSend, logger)
 	gossipActor := GossipActor{
@@ -111,7 +110,6 @@ func (ga *GossipActor) onGossipRequest(r *GossipRequest, ctx actor.Context) {
 	}
 
 	ctx.Respond(&GossipResponse{})
-	return
 
 	// turn off acking for now
 

cluster/gossiper.go

@@ -265,7 +265,7 @@ func (g *Gossiper) blockExpiredHeartbeats() {
 	for k, v := range t {
 		if k != g.cluster.ActorSystem.ID &&
 			!blockList.IsBlocked(k) &&
-			time.Now().Sub(time.UnixMilli(v.LocalTimestampUnixMilliseconds)) > g.cluster.Config.HeartbeatExpiration {
+			time.Since(time.UnixMilli(v.LocalTimestampUnixMilliseconds)) > g.cluster.Config.HeartbeatExpiration {
 			blocked = append(blocked, k)
 		}
 	}