Merge pull request #9 from pavog/php-84

PHP 8.4 compatability: Make parameter types explicitly nullable
aternosorg · Dec 13, 2024 · afcded8 · afcded8
2 parents 6e817e6 + c2d0a20
commit afcded8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/EtcdLock.php b/src/EtcdLock.php
@@ -25,7 +25,7 @@ class EtcdLock extends Lock implements LockInterface
      * @throws InvalidResponseStatusCodeException
      * @throws TooManySaveRetriesException
      */
-    public function __construct(string $key, bool $exclusive = false, int $time = 120, int $wait = 300, string $identifier = null)
+    public function __construct(string $key, bool $exclusive = false, int $time = 120, int $wait = 300, ?string $identifier = null)
     {
         parent::__construct($key);
         $this->lock($exclusive, $time, $wait, $identifier);

diff --git a/src/Lock.php b/src/Lock.php
@@ -262,7 +262,7 @@ public function __construct(string $key)
      * @throws InvalidResponseStatusCodeException
      * @throws TooManySaveRetriesException
      */
-    public function lock(bool $exclusive = false, int $time = 120, int $wait = 300, string $identifier = null): bool
+    public function lock(bool $exclusive = false, int $time = 120, int $wait = 300, ?string $identifier = null): bool
     {
         $this->exclusive = $exclusive;
         $this->time = $time;

diff --git a/src/LockInterface.php b/src/LockInterface.php
@@ -18,7 +18,7 @@ interface LockInterface
      * @param int $wait
      * @param string|null $identifier
      */
-    public function __construct(string $key, bool $exclusive = false, int $time = 60, int $wait = 300, string $identifier = null);
+    public function __construct(string $key, bool $exclusive = false, int $time = 60, int $wait = 300, ?string $identifier = null);
 
     /**
      * Check if is locked and returns time until lock runs out or false