Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed several issues with the knob control. #356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Mar 25, 2018

  1. Fixed several issues with the knob control.

    1. Control now gracefully handles empty input, falling back to zero
       instead of NaN.
    
    2. The control now also handles 'wheel' events instead of only
       'mousewheel' and 'DOMMouseScroll' events.
    
       Modern browsers use the W3C standard 'wheel' event when reporting
       scroll wheel events.
    
       This also prevents the site from scrolling when the cursor is over
       a knob and the mouse wheel or track pad scrolling is actuated.
    
       Previously, the web site would scroll away under the cursor as the
       user tried to actuate a knob with the scroll wheel or track pad,
       since the event was not properly captured.
    
    3. Increased the timeout for detecting mouse wheel stops from 100 ms
       to a more graceful 250 ms, which often works better.
    
    4. Removed the second timer (mwTimerRelease), since it messes things up.
    
    5. Added more key codes allowed for input, since the original set
       turned out too restrictive.
    
    6. Removed the speedup on long key presses, since this does not actually
       cause the increment to speed up, but instantly skips to the end of
       the range (min/max value) on a long press.
    andrepxx committed Mar 25, 2018
    Configuration menu
    Copy the full SHA
    0e29487 View commit details
    Browse the repository at this point in the history