fix numeric version check in a couple more places

ateucher · Jul 7, 2024 · c44b293 · c44b293
1 parent 4ee26a2
commit c44b293
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tests/testthat/helpers.R b/tests/testthat/helpers.R
@@ -3,7 +3,7 @@ has_sys_mapshaper <- function() {
 }
 
 skip_on_old_v8 <- function() {
-  if (v8_version() < 6) {
+  if (v8_version() < "6") {
     testthat::skip("Skipping due to old V8 engine")
   }
 }

diff --git a/tests/testthat/test-clip_erase.R b/tests/testthat/test-clip_erase.R
@@ -200,7 +200,7 @@ test_that("clip and erase fail properly", {
 })
 
 test_that("ms_clip and ms_erase fail with old v8", {
-  skip_if_not(v8_version() < 6, "Not old v8")
+  skip_if_not(v8_version() < "6", "Not old v8")
   expect_error(ms_clip(ce_poly, ce_inner_poly))
   expect_error(ms_erase(ce_poly, ce_inner_poly))
 })