Ensure validator specs require spec_helper
#500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blacksmoke16
added
kind:bug
PallasAthenaie
pushed a commit
to athena-framework/validator
that referenced
this pull request
Jan 24, 2025
…k/athena#500) * Move `Positive` spec into `constraints/` dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Avoids possible failures depending on how the glob resolves the files. Discovered via latest specs: https://github.com/athena-framework/athena/actions/runs/12941655549/job/36098067662
Changelog
AVD::Constraintspecs requirespec_helperAVD::Constraint::Positiveintospec/constraints/dirBefore merging, remember to add the
athena-framework/athenaprefix to the PR number in the PR title