set new pana

athena-sql · Nov 29, 2024 · f1a3f07 · f1a3f07
1 parent 7ed1938
commit f1a3f07
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 42 deletions.
diff --git a/.github/workflows/pana.yaml b/.github/workflows/pana.yaml
@@ -64,59 +64,35 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - uses: axel-op/dart-package-analyzer@v3
+      - uses: flutterings/dart-package-analyzer@v1
         id: analysis
         with:
-          githubToken: ${{ secrets.GITHUB_TOKEN }}
           relativePath: packages/athena_postgres
-      - name: Check scores
-        env:
-          # NB: "analysis" is the id set above. Replace it with the one you used if different.
-          TOTAL: ${{ steps.analysis.outputs.total }}
-          TOTAL_MAX: ${{ steps.analysis.outputs.total_max }}
-        run: |
-          if (( $TOTAL < 100 ))
-          then
-            echo Score too low!
-            exit 1
-          fi
+      - uses: fujidaiti/[email protected]
+        with:
+          report: ${{ steps.analysis.outputs.json_output }} # Required
+          min-pub-points: 120
   athena_sql:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - uses: axel-op/dart-package-analyzer@v3
+      - uses: flutterings/dart-package-analyzer@v1
         id: analysis
         with:
-          githubToken: ${{ secrets.GITHUB_TOKEN }}
           relativePath: packages/athena_sql
-      - name: Check scores
-        env:
-          # NB: "analysis" is the id set above. Replace it with the one you used if different.
-          TOTAL: ${{ steps.analysis.outputs.total }}
-          TOTAL_MAX: ${{ steps.analysis.outputs.total_max }}
-        run: |
-          if (( $TOTAL < 100 ))
-          then
-            echo Score too low!
-            exit 1
-          fi
+      - uses: fujidaiti/[email protected]
+        with:
+          report: ${{ steps.analysis.outputs.json_output }} # Required
+          min-pub-points: 120
   athena_utils:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - uses: axel-op/dart-package-analyzer@v3
+      - uses: flutterings/dart-package-analyzer@v1
         id: analysis
         with:
-          githubToken: ${{ secrets.GITHUB_TOKEN }}
           relativePath: packages/athena_utils
-      - name: Check scores
-        env:
-          # NB: "analysis" is the id set above. Replace it with the one you used if different.
-          TOTAL: ${{ steps.analysis.outputs.total }}
-          TOTAL_MAX: ${{ steps.analysis.outputs.total_max }}
-        run: |
-          if (( $TOTAL < 100 ))
-          then
-            echo Score too low!
-            exit 1
-          fi
+      - uses: fujidaiti/[email protected]
+        with:
+          report: ${{ steps.analysis.outputs.json_output }} # Required
+          min-pub-points: 120
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -1,3 +1,5 @@
+include: package:lints/core.yaml
+
 analyzer:
   plugins:
     - dart_code_metrics

diff --git a/packages/athena_mysql/lib/src/athena_mysql_base.dart b/packages/athena_mysql/lib/src/athena_mysql_base.dart
@@ -83,7 +83,6 @@ class MySqlTransactionSQLDriver extends AthenaDatabaseDriver {
   Future<AthenaQueryResponse> execute(
     String queryString, {
     Map<String, dynamic>? mapValues,
-    bool? iterable,
   }) async {
     final mapper = QueryMapper(prefixQuery: '?');
 
@@ -93,8 +92,7 @@ class MySqlTransactionSQLDriver extends AthenaDatabaseDriver {
       final mapped = result.rows.map((e) => QueryRow(e.typedAssoc())).toList();
       return QueryResponse(mapped);
     }
-    final prepared =
-        await connection.prepare(queryToExecute.query, iterable ?? true);
+    final prepared = await connection.prepare(queryToExecute.query, true);
 
     final result = await prepared.execute(queryToExecute.args);
 

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -3,4 +3,5 @@ name: athena_sql_workspace
 environment:
   sdk: '>=3.5.0 <4.0.0'
 dev_dependencies:
+  lints: ^5.0.0
   melos: ^6.2.0