Skip to content

Commit

Permalink
fix(build): Add remote function benchmark under benchmark flags (face…
Browse files Browse the repository at this point in the history
…bookincubator#11905)

Summary:
The remote function benchmarks are built without checking if the benchmark utilities are being built. These are only built if certain flags are set.

This causes upstream issues in Prestissimo because there remote functions are being built but the benchmarks are not.

PR introducing the breaking change:
facebookincubator#11539

Pull Request resolved: facebookincubator#11905

Reviewed By: kagamiori

Differential Revision: D67403110

Pulled By: kgpai

fbshipit-source-id: 62955ddbc540d4397dce094816496c4d87d035a3
  • Loading branch information
czentgr authored and athmaja-n committed Jan 10, 2025
1 parent 5bdbedc commit c316f93
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion velox/functions/remote/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,6 @@ add_subdirectory(if)
add_subdirectory(client)
add_subdirectory(server)
add_subdirectory(utils)
add_subdirectory(benchmarks)
if(${VELOX_ENABLE_BENCHMARKS})
add_subdirectory(benchmarks)
endif()

0 comments on commit c316f93

Please sign in to comment.