Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(highlight-driver-setting): Add highlight prop #396

Merged
merged 2 commits into from
Jun 24, 2024
Merged

feat(highlight-driver-setting): Add highlight prop #396

merged 2 commits into from
Jun 24, 2024

Conversation

regnerus
Copy link
Contributor

@regnerus regnerus commented Jun 12, 2024 •
edited
Loading

Adds the ability to highlight specific driver settings.

@regnerus regnerus requested a review from nozols June 12, 2024 12:29
nozols
nozols requested changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@nozols nozols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The highlight property should be added to each of the oneof fields of driverSettings.items. Validation currently only works for settings of type text, password, input and label. But it doesn't work for all other setting types.

@regnerus regnerus requested a review from nozols June 21, 2024 13:10
@RobinBol RobinBol merged commit 5fb4ef5 into develop Jun 24, 2024
2 checks passed
@RobinBol RobinBol deleted the feature/highlight-setting branch June 24, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nozols nozols nozols approved these changes

Assignees

@RobinBol RobinBol

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@regnerus @nozols @RobinBol