-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump-up test_allocator dub version to 0.2.0 #19
Bump-up test_allocator dub version to 0.2.0 #19
Conversation
@@ -18,7 +18,7 @@ | |||
"excludedSourceFiles": ["src/main.d"], | |||
"dependencies": { | |||
"unit-threaded": "~>0.7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While at it, shouldn't unit-threaded
be at 0.7.43, as in dub.selections.json
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because of this dub bug. I dare not even update uni-threaded to 0.8 or it'd break everything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because of this dub bug. I dare not even bump up unit-threaded to 0.8 or else everything would break.
@@ -29,7 +29,7 @@ | |||
"excludedSourceFiles": ["src/main.d"], | |||
"dependencies": { | |||
"unit-threaded": "~>0.7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
@atilaneves @wilzbach I'm guessing the On my machine everything runs just fine with |
The CI compilers can't have that fix - they're set versions. I guess the way forward is to version the changes to test_allocator depending on the compiler version. |
24a6f74
to
177a073
Compare
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
=======================================
Coverage 98.88% 98.88%
=======================================
Files 7 7
Lines 628 628
=======================================
Hits 621 621
Misses 7 7 Continue to review full report at Codecov.
|
@atilaneves this bumps |
@atilaneves Thank you. Could you create a new |
@edi33416 Done. |
Following up this
TestAllocator
PR, this is updating the dub version for the test_allocator package to0.2.0
I'm guessing this is the next step in unblocking this
Phobos
PRCheers,
Eduard