Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump-up test_allocator dub version to 0.2.0 #19

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

edi33416
Copy link
Contributor

@edi33416 edi33416 commented Apr 19, 2018

Following up the TestAllocator PR, this is updating the dub version for the test_allocator package to 0.1.1

Following up this TestAllocator PR, this is updating the dub version for the test_allocator package to 0.2.0
I'm guessing this is the next step in unblocking this Phobos PR

Cheers,
Eduard

@@ -18,7 +18,7 @@
"excludedSourceFiles": ["src/main.d"],
"dependencies": {
"unit-threaded": "~>0.7.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While at it, shouldn't unit-threaded be at 0.7.43, as in dub.selections.json?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because of this dub bug. I dare not even update uni-threaded to 0.8 or it'd break everything.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because of this dub bug. I dare not even bump up unit-threaded to 0.8 or else everything would break.

@@ -29,7 +29,7 @@
"excludedSourceFiles": ["src/main.d"],
"dependencies": {
"unit-threaded": "~>0.7.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@edi33416
Copy link
Contributor Author

@atilaneves @wilzbach I'm guessing the CI is failing because the compilers don't have this dmd fix?

On my machine everything runs just fine with DMD64 D Compiler v2.078.0-1185-g44d849e

@atilaneves
Copy link
Owner

The CI compilers can't have that fix - they're set versions. I guess the way forward is to version the changes to test_allocator depending on the compiler version.

@edi33416 edi33416 force-pushed the bump_dub_test_allocator_ver branch from 24a6f74 to 177a073 Compare April 24, 2018 11:14
@edi33416 edi33416 changed the title Bump-up test_allocator dub version to 0.1.1 Bump-up test_allocator dub version to 0.2.0 Apr 24, 2018
@codecov-io
Copy link

codecov-io commented Apr 24, 2018

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files           7        7           
  Lines         628      628           
=======================================
  Hits          621      621           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35c5415...177a073. Read the comment docs.

@edi33416
Copy link
Contributor Author

@atilaneves this bumps test_allocator to version 0.2.0 which uses the stdx-allocator snapshot

@atilaneves atilaneves merged commit c4a3345 into atilaneves:master Apr 24, 2018
@edi33416
Copy link
Contributor Author

@atilaneves Thank you.

Could you create a new tag so this change get's into dub? That way Jenkins can use the latest version and pass the project. Thanks

@atilaneves
Copy link
Owner

@edi33416 Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants