Merge pull request #1 from atkulp/develop

v1.2 Fixed issue with locating paths with spaces, updated icon

README.md

@@ -1,20 +1,28 @@
-StringAsFilenameDebuggerVisualizer
+Debugger Visualizer Pack by Arian
 ==================================
 
 Arian T. Kulp
 -------------
 
-Debugger visualizers for Visual Studio 2017 to open/view files by taking a string
+Debugger Visualizer Pack by Arian for Visual Studio 2017 lets you open/view files by taking a string
 variable value as the filename.
 
 Install using prebuilt VSIX or install manually by copying the built DLL
 (ArianKulp.DebuggerExtensions.dll) to \$UserProfileStudio 2017.
 
+You can also add this extension from the **Tools | Extensions and Updates** menu 
+in Visual Studio or from the [Visual Studio Gallery](https://marketplace.visualstudio.com/items?itemName=ArianKulp.DebuggerVisualizerPackbyArian).
+
 Note, this actually adds multiple visualizers so you can locate the file in Windows Explorer, open the file in Visual
 Studio (without adding it to the project/solution), or in Notepad.
 
 ### Release History
 
+-   v1.2
+
+    -   Fixed issue with paths with spaces opening in Windows Explorer
+    -   Added better icon
+
 -   v1.1
 
     -   Update to proper installation of visualizer via VSIX
@@ -36,4 +44,7 @@ None at the moment
 -   Possibly add option to save current string value into temp file and then
     open it
 
--   Add option to Peek at file contents in current window
+-   Add option to Peek at file contents in current window
+
+### Attributions
+File Search icon by Chanut is Industries from the Noun Project

Solution/Package/Package.csproj

@@ -12,7 +12,7 @@
     <AssemblyOriginatorKeyFile>Key.snk</AssemblyOriginatorKeyFile>
   </PropertyGroup>
   <PropertyGroup>
-    <ApplicationIcon>Resources\StringDebuggerPackage.ico</ApplicationIcon>
+    <ApplicationIcon>Resources\noun_586565_cc.ico</ApplicationIcon>
   </PropertyGroup>
   <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
   <PropertyGroup>
@@ -62,12 +62,6 @@
       <SubType>Designer</SubType>
     </None>
   </ItemGroup>
-  <ItemGroup>
-    <Content Include="Resources\StringDebuggerPackage.ico">
-      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
-      <IncludeInVSIX>true</IncludeInVSIX>
-    </Content>
-  </ItemGroup>
   <ItemGroup>
     <Reference Include="EnvDTE, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a">
       <EmbedInteropTypes>False</EmbedInteropTypes>
@@ -158,6 +152,12 @@
       <Name>StringExtensions</Name>
     </ProjectReference>
   </ItemGroup>
+  <ItemGroup>
+    <Content Include="Resources\noun_586565_cc.ico">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+      <IncludeInVSIX>true</IncludeInVSIX>
+    </Content>
+  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <Import Project="$(VSToolsPath)\VSSDK\Microsoft.VsSDK.targets" Condition="'$(VSToolsPath)' != ''" />
   <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">

Solution/Package/Properties/AssemblyInfo.cs

@@ -29,5 +29,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.1.0.0")]
-[assembly: AssemblyFileVersion("1.1.0.0")]
+[assembly: AssemblyVersion("1.2.0.0")]
+[assembly: AssemblyFileVersion("1.2.0.0")]

Solution/Package/source.extension.vsixmanifest

@@ -1,10 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
 <PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
     <Metadata>
-        <Identity Id="StringOpenFileDebugger.8386b8d5-d629-4ebc-a6f8-d41cdc1342fb" Version="1.1" Language="en-US" Publisher="Arian T. Kulp" />
+        <Identity Id="StringOpenFileDebugger.8386b8d5-d629-4ebc-a6f8-d41cdc1342fb" Version="1.2" Language="en-US" Publisher="Arian T. Kulp" />
         <DisplayName>Debugger Visualizer Pack by Arian</DisplayName>
         <Description xml:space="preserve">Various debugging visualizers including open file from filename in string variable.</Description>
-        <Icon>Resources\StringDebuggerPackage.ico</Icon>
+        <Icon>Resources\noun_586565_cc.ico</Icon>
         <Tags>debugger, string, visualizer, open file</Tags>
     </Metadata>
     <Installation>

Solution/StringExtensions/Properties/AssemblyInfo.cs

@@ -32,5 +32,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.1.0.0")]
-[assembly: AssemblyFileVersion("1.1.0.0")]
+[assembly: AssemblyVersion("1.2.0.0")]
+[assembly: AssemblyFileVersion("1.2.0.0")]

Solution/StringExtensions/StringOpenFileDebuggerExtension.cs

@@ -68,15 +68,18 @@ override protected void Show(IDialogVisualizerService windowService, IVisualizer
 
             if (fn != null && ServiceProvider.GlobalProvider.GetService(typeof(DTE)) is DTE2 dte2)
             {
-                if (!File.Exists(fn))
+                if (!File.Exists(fn) && !Directory.Exists(fn))
                 {
-                    ShowError("File does not exist");
+                    ShowError("File/folder does not exist");
                     return;
                 }
 
+                var attr = File.GetAttributes(fn);
+                var isFolder = (attr & FileAttributes.Directory) != 0;
+
                 // combine the arguments together
                 // it doesn't matter if there is a space after ','
-                string argument = "/select, \"" + fn + "\"";
+                string argument = isFolder ? $"\"{fn}\"" : $"/select, \"{fn}\"";
 
                 System.Diagnostics.Process.Start("explorer.exe", argument);
             }