Skip to content

Commit

Permalink
Delete nyxt/sbmodules system.
Browse files Browse the repository at this point in the history
  • Loading branch information
aadcg committed Apr 1, 2024
1 parent bb19c9e commit 52e8cfb
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 105 deletions.
9 changes: 4 additions & 5 deletions INSTALL
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,10 @@ it is set to $PREFIX/share/.

NASDF_TESTS_NO_NETWORK disables tests that require networking.

When NYXT_SUBMODULES is "true" (the default), all Lisp dependencies are fetched
as git submodules to the directory set by NASDF_SUBMODULES_DIR. Otherwise, they
need to be made visible to ASDF by other means. In case you have received an
archive that includes the source of these Lisp dependencies, then it all should
work out of the box.
When NYXT_SUBMODULES is "true" (the default), all Lisp dependencies are searched
at ./_build. Otherwise, they need to be made visible to ASDF by other means.
In case you have received an archive that includes the source of these Lisp
dependencies, then it all should work out of the box.

NYXT_RENDERER sets the renderer, by default "gi-gtk".

Expand Down
3 changes: 0 additions & 3 deletions libraries/nasdf/nasdf.asd
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
;;;; SPDX-FileCopyrightText: Atlas Engineer LLC
;;;; SPDX-License-Identifier: BSD-3-Clause

;; Can't depend on CL libraries, because it's in charge of fetching them as git
;; submodules.
(defsystem "nasdf"
:version "0.1.8"
:author "Atlas Engineer LLC"
Expand All @@ -12,6 +10,5 @@
(:file "log")
(:file "nasdf")
(:file "install")
(:file "submodules")
(:file "systems")
(:file "tests")))
17 changes: 1 addition & 16 deletions libraries/nasdf/package.lisp
Original file line number Diff line number Diff line change
Expand Up @@ -34,22 +34,7 @@ A test system:
:class :nasdf-test-system
:depends-on (alexandria lisp-unit2)
:components ((:file \"tests\"))
:test-suite-args (:package :my-project/tests))
A system that fetches the Git submodules:
(defsystem \"my-project/submodules\"
:defsystem-depends-on (\"nasdf\")
:class :nasdf-submodule-system)
Shell command to add a submodule to the default directory:
git submodule add https://github.com/atlas-engineer/history-tree _build/history-tree
To update it:
git submodule update --remote _build/history-tree
"))
:test-suite-args (:package :my-project/tests))"))

#+sb-package-locks
(sb-ext:lock-package :nasdf)
2 changes: 0 additions & 2 deletions libraries/nasdf/readme.org
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ See [[file:package.lisp]] for more details.
NASDF exposes the following environment variables for convenience:

- =NASDF_SOURCE_PATH= :: See =nasdf:*dest-source-dir*=.
- =NASDF_SUBMODULES_DIR= :: See =nasdf:*submodules-directory*=.
- =NASDF_SUBMODULES_JOBS= :: See =nasdf:*submodules-jobs*=.
- =NASDF_USE_LOGICAL_PATHS= :: Allow non-expanded logical pathnames in system
pathnames.
This is particularly useful when shipping the source.
Expand Down
74 changes: 0 additions & 74 deletions libraries/nasdf/submodules.lisp

This file was deleted.

3 changes: 2 additions & 1 deletion makefile
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,10 @@ help:

makefile_dir := $(dir $(abspath $(lastword $(MAKEFILE_LIST))))

# TODO warn if _build is empty; instruct to populate git submodules
lisp_eval:=$(LISP) $(LISP_FLAGS) \
--eval '(require "asdf")' \
--eval '(when (string= "$(NYXT_SUBMODULES)" "true") (setf asdf:*default-source-registries* (list (quote asdf/source-registry:environment-source-registry))) (asdf:clear-configuration) (asdf:load-asd "$(makefile_dir)/libraries/nasdf/nasdf.asd") (asdf:load-asd "$(makefile_dir)/nyxt.asd") (asdf:load-system :nyxt/submodules))' \
--eval '(when (string= "$(NYXT_SUBMODULES)" "true") (setf (uiop:getenv "CL_SOURCE_REGISTRY") "$(makefile_dir)_build//:$(makefile_dir)") (asdf:clear-configuration))' \
--eval '(asdf:load-asd "$(makefile_dir)/libraries/nasdf/nasdf.asd")' \
--eval '(asdf:load-asd "$(makefile_dir)/nyxt.asd")' \
--eval
Expand Down
4 changes: 0 additions & 4 deletions nyxt.asd
Original file line number Diff line number Diff line change
Expand Up @@ -227,10 +227,6 @@
(test-op "nyxt/analysis")
(test-op "nyxt/theme"))))

(defsystem "nyxt/submodules"
:defsystem-depends-on ("nasdf")
:class :nasdf-submodule-system)

(defsystem "nyxt/tests"
:defsystem-depends-on ("nasdf")
:class :nasdf-test-system
Expand Down

0 comments on commit 52e8cfb

Please sign in to comment.