Code

WIP: Minibuffer overhaul#1054

Code

Closed

Ambrevar wants to merge 119 commits intomasteratlas-engineer/nyxt:masterfrom minibuffer-overhaulatlas-engineer/nyxt:minibuffer-overhaulCopy head branch name to clipboard

+2,173-44

Commits

Commits on Dec 11, 2020

• libraries/class-star: Patch process-slot-definition to avoid exporting missing accessor.

  Ambrevar

  committed
  770d39b

  Copy full SHA for 770d39b

• libraries/minibuffer: Initialize.

  Ambrevar

  committed
  bb2ee1d

  Copy full SHA for bb2ee1d

• Rename keep-exact-matches-in-suggestions to delete-inexact-matches.

  Ambrevar

  committed
  8ddf574

  Copy full SHA for 8ddf574

• nyxt.asd: Add mk-string-metrics and trivial-package-local-nicknames to minibuffer system.

  Ambrevar

  committed
  bcf85df

  Copy full SHA for bcf85df

• libraries/minibuffer: Rename initializer and cleanup to constructor and desctructor.

  Ambrevar

  committed
  4bf8fa4

  Copy full SHA for 4bf8fa4

• libraries/minibuffer: Rename ready? to ready-p.

  Show description for 329374c
  Ambrevar

  committed
  329374c

  Copy full SHA for 329374c

• Draft: Try using dummy text widget to accept input methods. Does not work.

  Show description for d5204f0
  Ambrevar

  committed
  d5204f0

  Copy full SHA for d5204f0

• Forward event even when minibuffer is up.

  Ambrevar

  committed
  eaa161f

  Copy full SHA for eaa161f

Commits on Dec 20, 2020

• Revert "Forward event even when minibuffer is up."

  Show description for a1a4a21
  Ambrevar

  committed
  a1a4a21

  Copy full SHA for a1a4a21

• Revert "Draft: Try using dummy text widget to accept input methods. Does not work."

  Show description for b473f08
  Ambrevar

  committed
  b473f08

  Copy full SHA for b473f08

• GTK: Fix typo in %within-renderer-thread docstring.

  Ambrevar

  committed
  daef71a

  Copy full SHA for daef71a

• DRAFT: Add HTML input tag and read from it.

  Ambrevar

  committed
  83fd8d9

  Copy full SHA for 83fd8d9

• Revert "DRAFT: Add HTML input tag and read from it."

  Show description for 39ff4bf
  Ambrevar

  committed
  39ff4bf

  Copy full SHA for 39ff4bf

• Add ffi-minibuffer-evaluate-javascript / ffi-minibuffer-evaluate-javascript-async.

  Ambrevar

  committed
  ccb32bb

  Copy full SHA for ccb32bb

• libraries/minibuffer: Rename to "prompter".

  Ambrevar

  committed
  cfe9892

  Copy full SHA for cfe9892

• dir-locals: Add ffi-method.

  Ambrevar

  committed
  5724e77

  Copy full SHA for 5724e77

• libraries/prompter: Finish renaming minibuffer' to prompter'.

  Ambrevar

  committed
  6b409f2

  Copy full SHA for 6b409f2

• libraries/prompter: Add yes-no source.

  Ambrevar

  committed
  2be9e36

  Copy full SHA for 2be9e36

• Draft: Initial prompt-buffer implementation.

  Ambrevar

  committed
  12cf63f

  Copy full SHA for 12cf63f

Commits on Dec 21, 2020

• libraries/prompter: Disable must-match-p if there is no filter.

  Ambrevar

  committed
  5bbdf8d

  Copy full SHA for 5bbdf8d

• libraries/prompter: Add return-selection.

  Ambrevar

  committed
  e84e66b

  Copy full SHA for e84e66b

• libraries/prompter: Fix test indentation and warning.

  Ambrevar

  committed
  a7ee4f0

  Copy full SHA for a7ee4f0

• libraries/prompter: Add "Return result" test.

  Ambrevar

  committed
  95d908e

  Copy full SHA for 95d908e

• Draft: Prepare source to welcome prompt-buffer.

  Ambrevar

  committed
  95876fa

  Copy full SHA for 95876fa

• prompt-buffer-mode: Simplify return-selection, add cancel-input, remove bindings.

  Show description for 27a84cd
  Ambrevar

  committed
  27a84cd

  Copy full SHA for 27a84cd

• Draft: prompt-buffer: Prepare and fix compilation.

  Ambrevar

  committed
  c1359b8

  Copy full SHA for c1359b8

• libraries/prompter: Allow must-match-p to be nil.

  Ambrevar

  committed
  edcce23

  Copy full SHA for edcce23

• prompt-buffer: Get set-url2 to not fail.

  Ambrevar

  committed
  ada61ee

  Copy full SHA for ada61ee

• Draft: prompt-buffer: Fix init display.

  Ambrevar

  committed
  c91f57a

  Copy full SHA for c91f57a

• libraries/prompter: Don't destroy the minibuffer when returning selection.

  Show description for de3c9ad
  Ambrevar

  committed
  de3c9ad

  Copy full SHA for de3c9ad

• Draft: prompt-buffer: Handle escape input.

  Ambrevar

  committed
  54ad31e

  Copy full SHA for 54ad31e

• Draft: prompt-buffer: Display suggestions.

  Ambrevar

  committed
  aab2e46

  Copy full SHA for aab2e46

• Draft: prompt-buffer: Refresh candidate list on input change.

  Ambrevar

  committed
  1a87eb2

  Copy full SHA for 1a87eb2

• libraries/prompter: Mitigate error when cancelling thread.

  Ambrevar

  committed
  0c2c6fe

  Copy full SHA for 0c2c6fe

Commits on Dec 22, 2020

• Draft: prompt-buffer: Update some comments.

  Ambrevar

  committed
  addf23e

  Copy full SHA for addf23e

• libraries/prompter: Fix initial suggestion destruction on update.

  Ambrevar

  committed
  5bc06f8

  Copy full SHA for 5bc06f8

• libraries/prompter: Include all suggestions on empty input.

  Ambrevar

  committed
  d2c203b

  Copy full SHA for d2c203b

• prompt-buffer: Display counts.

  Ambrevar

  committed
  78f766a

  Copy full SHA for 78f766a

• prompt-buffer: Restore style.

  Ambrevar

  committed
  283b078

  Copy full SHA for 283b078

• prompt-buffer: Remove unreachable branch in update-suggestion-html.

  Ambrevar

  committed
  dbdb853

  Copy full SHA for dbdb853

• prompt-buffer: Print multiple columns.

  Ambrevar

  committed
  b8d2b72

  Copy full SHA for b8d2b72

• libraries/prompter: Add select-next and select-previous.

  Ambrevar

  committed
  18290d0

  Copy full SHA for 18290d0

• libraries/prompter: Return value in return-selection.

  Ambrevar

  committed
  1cfe472

  Copy full SHA for 1cfe472

• libraries/prompter: Fix channel initialization in source.

  Ambrevar

  committed
  e3d6ba1

  Copy full SHA for e3d6ba1

• Draft: prompt-buffer: Add select-next and select-previous commands.

  Ambrevar

  committed
  7f5a77b

  Copy full SHA for 7f5a77b

Commits on Dec 23, 2020

• prompt-buffer: Scroll into view when selection moves.

  Ambrevar

  committed
  8c9c7a0

  Copy full SHA for 8c9c7a0

• prompt-buffer: List suggestions around cursor.

  Ambrevar

  committed
  1d61ad3

  Copy full SHA for 1d61ad3

• libraries/prompter: Accept STEPS argument in select functions.

  Ambrevar

  committed
  3ff723e

  Copy full SHA for 3ff723e

• prompt-buffer: Add next-page command.

  Ambrevar

  committed
  ae3ddfd

  Copy full SHA for ae3ddfd

• libraries/prompter: Simplify and fix `select'.

  Ambrevar

  committed
  0703c1c

  Copy full SHA for 0703c1c

• libraries/prompter: Fix overflow on last element in `select'.

  Ambrevar

  committed
  3a2b04f

  Copy full SHA for 3a2b04f

• prompt-buffer: Add select-previous-page.

  Ambrevar

  committed
  f37f240

  Copy full SHA for f37f240

• Draft: prompt-buffer: Attempt to fix HTML overflow in suggestion table.

  Ambrevar

  committed
  3681213

  Copy full SHA for 3681213

• prompt-buffer: Add copy-selection.

  Ambrevar

  committed
  6196b52

  Copy full SHA for 6196b52

• prompt-buffer: Add prompt-buffer-paste.

  Ambrevar

  committed
  1416363

  Copy full SHA for 1416363

• Fix %paste moving input tag cursor.

  Ambrevar

  committed
  b2af8d3

  Copy full SHA for b2af8d3

• libraries/prompter: Fix return-selection on selection.

  Ambrevar

  committed
  cc5c9d9

  Copy full SHA for cc5c9d9

• libraries/prompter: Add return-input.

  Ambrevar

  committed
  789a1aa

  Copy full SHA for 789a1aa

• prompt-buffer: Add return-input.

  Ambrevar

  committed
  aa3558b

  Copy full SHA for aa3558b

• prompt-buffer-mode: Fix export conflict with `start'.

  Ambrevar

  committed
  b205b8c

  Copy full SHA for b205b8c

• prompt-buffer: Add toggle-mark and toggle-mark-backwards.

  Ambrevar

  committed
  ac13f9f

  Copy full SHA for ac13f9f

• prompt-buffer: Add current-source and current-selection helpers.

  Ambrevar

  committed
  254a189

  Copy full SHA for 254a189

• prompt-buffer: Add marked-suggestions helper.

  Ambrevar

  committed
  9823caf

  Copy full SHA for 9823caf

• prompt-buffer: Support marks in copy-selection.

  Ambrevar

  committed
  e7885a1

  Copy full SHA for e7885a1

• prompt-buffer: Add mark-all, unmark-all, toggle-mark-all.

  Ambrevar

  committed
  66a387f

  Copy full SHA for 66a387f

Commits on Dec 26, 2020

• libraries/prompter: Add selected-source, selected-suggestion, all-marked-suggestions.

  Ambrevar

  committed
  d96e3fb

  Copy full SHA for d96e3fb

• prompt-buffer: Rename current-selection and prompt-buffer-marked-suggestions.

  Show description for d9c956c
  Ambrevar

  committed
  d9c956c

  Copy full SHA for d9c956c

• libraries/prompter: Add select-first, select-last.

  Ambrevar

  committed
  f725a6e

  Copy full SHA for f725a6e

• prompt-buffer: Bind select-first, select-last to M-< and M->.

  Ambrevar

  committed
  1958dee

  Copy full SHA for 1958dee

• libraries/prompter: Add select-next-source and select-previous-source.

  Ambrevar

  committed
  2c0cbd0

  Copy full SHA for 2c0cbd0

• prompt-buffer: Bind select-next-source and select-previous-source to M-] and M-[.

  Ambrevar

  committed
  e940a9a

  Copy full SHA for e940a9a

Commits on Dec 27, 2020

• libraries/prompter: Include input in suggestions if there is no preprocessor.

  Ambrevar

  committed
  31456a6

  Copy full SHA for 31456a6

• prompt-buffer: Use new global-history-source and new-url-source in set-url2.

  Ambrevar

  committed
  57c68e5

  Copy full SHA for 57c68e5

• prompt-buffer: Add workaround for source without suggestions.

  Ambrevar

  committed
  8927d61

  Copy full SHA for 8927d61

• libraries/prompter: Maybe fix ready-p when called multiple times.

  Ambrevar

  committed
  6aae366

  Copy full SHA for 6aae366

• libraries/prompter: Notify when individual sources are ready.

  Ambrevar

  committed
  3d37ca8

  Copy full SHA for 3d37ca8

• libraries/prompter: Fix possible race condition when resetting ready-channel.

  Ambrevar

  committed
  a2e5c95

  Copy full SHA for a2e5c95

• libraries/prompter: Simplify all-ready-p.

  Show description for 80b5db0
  Ambrevar

  committed
  80b5db0

  Copy full SHA for 80b5db0

• prompt-buffer: Print multiple sources together, update them independently.

  Ambrevar

  committed
  49bff4b

  Copy full SHA for 49bff4b

• libraries/prompter: Fix skipping of next suggestion when at end of source.

  Show description for b1e5b3e
  Ambrevar

  committed
  b1e5b3e

  Copy full SHA for b1e5b3e

Commits on Dec 29, 2020

• libraries/prompter: Fix race condition with next-ready-p.

  Ambrevar

  committed
  06e0af7

  Copy full SHA for 06e0af7

• libraries/prompter: Make `name' slot mandatory for sources.

  Ambrevar

  committed
  a6adca9

  Copy full SHA for a6adca9

• libraries/prompter: Use exported slots of structures and classes in object-properties.

  Ambrevar

  committed
  9ae383d

  Copy full SHA for 9ae383d

Commits on Dec 30, 2020

• libraries/prompter: Add action helpers.

  Ambrevar

  committed
  87d014a

  Copy full SHA for 87d014a

• package: Import define-class in nyxt-user and prompt-buffer-mode.

  Ambrevar

  committed
  db8c6cb

  Copy full SHA for db8c6cb

• prompt-buffer: Fix race condition with current-source in update-suggestion-html.

  Show description for 1da17f2
  Ambrevar

  committed
  1da17f2

  Copy full SHA for 1da17f2

• prompt-buffer: Add initial action support.

  Ambrevar

  committed
  60ac9df

  Copy full SHA for 60ac9df

• libraries/prompter: Unexport `selection'.

  Show description for 484cbbb
  Ambrevar

  committed
  484cbbb

  Copy full SHA for 484cbbb

• prompt-buffer: Don't use unexported `selection', use helpers instead.

  Ambrevar

  committed
  8a1589d

  Copy full SHA for 8a1589d

• libraries/prompter: Have return-selection run the default action.

  Show description for d0be2fe
  Ambrevar

  committed
  d0be2fe

  Copy full SHA for d0be2fe

• prompt-buffer: Have return-selection run the default action.

  Ambrevar

  committed
  abc7f69

  Copy full SHA for abc7f69

• Replace nested let with let*.

  Ambrevar

  committed
  ced33ed

  Copy full SHA for ced33ed

• prompt-buffer: Display actions properties (name and docstring).

  Ambrevar

  committed
  8d2b7a3

  Copy full SHA for 8d2b7a3

• Draft: Add switch-buffer2 (using prompt-buffer).

  Ambrevar

  committed
  e6c99d1

  Copy full SHA for e6c99d1

• libraries/prompter: Rename and fix the destructor' method to a destroy' function.

  Ambrevar

  committed
  2497075

  Copy full SHA for 2497075

• prompt-buffer: Rename destructor' to destroy'.

  Ambrevar

  committed
  bfed892

  Copy full SHA for bfed892

• prompt-buffer: Clean up `value' dereferencing.

  Ambrevar

  committed
  b651db9

  Copy full SHA for b651db9

• prompt-buffer: Implement persistent actions.

  Ambrevar

  committed
  c8fb7ca

  Copy full SHA for c8fb7ca

• libraries/prompter: Call persistent action when follow-p is non-nil.

  Ambrevar

  committed
  8866e62

  Copy full SHA for 8866e62

• libraries/prompter: Call source destructor also over prompter and set returned-p.

  Ambrevar

  committed
  ebec9f1

  Copy full SHA for ebec9f1

• prompt-buffer: Replace manual invokation with `call-persistent-action'.

  Ambrevar

  committed
  f1d93fa

  Copy full SHA for f1d93fa

• prompt-buffer: Enable follow-p' for buffer-source'.

  Ambrevar

  committed
  3d6f6d9

  Copy full SHA for 3d6f6d9

• libraries/prompter: Add toggle-follow.

  Ambrevar

  committed
  37e8cef

  Copy full SHA for 37e8cef

• prompt-buffer: Bind "C-c C-f" to toggle-follow.

  Ambrevar

  committed
  1333847

  Copy full SHA for 1333847

Commits on Jan 25, 2021

• prompt-buffer.lisp: add style for top of input area

  Show description for 198dfc1
  jmercouris

  committed
  198dfc1

  Copy full SHA for 198dfc1

• prompt-buffer.lisp: rename prompt-input -> prompt-area

  Show description for 95c53b7
  jmercouris

  committed
  95c53b7

  Copy full SHA for 95c53b7

• prompt-buffer.lisp: remove commented code, updated elsewhere

  Show description for 63fe08f
  jmercouris

  committed
  63fe08f

  Copy full SHA for 63fe08f

• prompt-buffer.lisp: update suggestions style

  Show description for 5f45306
  jmercouris

  committed
  5f45306

  Copy full SHA for 5f45306

• prompt-buffer.lisp: set max-suggestion-count to 10

  Show description for 23f4a9d
  jmercouris

  committed
  23f4a9d

  Copy full SHA for 23f4a9d

Commits on Jan 26, 2021

• prompt-buffer.lisp: show lighthouse symbol next to source name

  jmercouris

  committed
  e4161dd

  Copy full SHA for e4161dd

• prompt-buffer.lisp: indent suggestions from a source-name

  jmercouris

  committed
  99f1409

  Copy full SHA for 99f1409

• prompt-buffer.lisp: remove UPCASE CAPITALIZATION from properties/columns

  jmercouris

  committed
  150379e

  Copy full SHA for 150379e

• prompt-buffer.lisp: tweak appearance of prompt buffer area

  jmercouris

  committed
  f895410

  Copy full SHA for f895410

• prompt-buffer.lisp: rename "cursor" -> "selection"

  jmercouris

  committed
  37fc55c

  Copy full SHA for 37fc55c

Commits on Jan 27, 2021

• renderer-gtk.lisp: set the focus of the widget when switching buffers

  jmercouris

  committed
  682074e

  Copy full SHA for 682074e

• renderer-gtk.lisp: set to the focus to the minibuffer if its height is set

  jmercouris

  committed
  b98c70e

  Copy full SHA for b98c70e

Commits on Jan 29, 2021

• prompt-buffer.lisp: redesign appearance of minibuffer

  jmercouris

  committed
  d392486

  Copy full SHA for d392486

• prompt-buffer.lisp: remove element-in-view-port code

  Show description for 2eeafba
  jmercouris

  committed
  2eeafba

  Copy full SHA for 2eeafba

• prompt-buffer.lisp: clip overflowed content

  jmercouris

  committed
  1b42036

  Copy full SHA for 1b42036