Nyxt-native dialogs!

[aartaka]

This adds handing of script-dialog WebKit signal and opens our pretty prompt-buffer instead of WebKit menus, and echoes JS alerts to the message-buffer instead of creating small alerts getting in the way.

[aartaka]

A small screenshot to get you teased :)

[aartaka]

Keep in mind that it only works on the latest version of cl-webkit.

[aartaka]

Mergeable. Thing to do:

• Before merging this:
  • Update submodule version for cl-webkit.
• After merging:
  • Add mouse support to prompt-buffer, because we need support equal amount of input devices as built-in dialogs (#1213).
  • Kill web-views properly, so that user gets "Are you sure you want to close this page and lose your input there?" messages.

[aartaka]

I've added file-chooser handing with Nyxt-native interface. It handles multiple file input elegantly, fetches an already existing value and works nice in general. I believe something can be done to color-chooser too, but for that we need to somehow add color parsing (is there any CSS-compatible library for that?).

In general, lots of WebKit UI can be replaced with prompt-buffer (including permission requests and notifications). Maybe introduce a browser-based switch for Nyxt-native UIs? Something like nyxt-native-dialogs.

[jmercouris]

I think a browser based switch is a good idea! I can't think of a color picker outside of the one when you invoke open-inspector. There are many JS based ones of course... Maybe we could provide a prompt buffer that includes a few sources for different 'standard' colors?

[jmercouris]

Nothing is to stop us for providing an emacs-like color picker experience :-D

[aartaka]

I think a browser based switch is a good idea! I can't think of a color picker outside of the one when you invoke open-inspector. There are many JS based ones of course...

What we can do is compile user input to CSS, insert it to a page and fetch its color with JavaScript. Terribly hacky, but really convenient. We can even use prompt-buffer's input line as this styled element!

Maybe we could provide a prompt buffer that includes a few sources for different 'standard' colors?

Yes, that could be an option too.

[jmercouris]

I don't think most people are comfortable translating from hex to a color. I can imagine what a color would be, but I can't be certain, and I've been doing it a long time. I guess it could be the first 'raw' user input source in the prompt buffer.

[aartaka]

I don't think most people are comfortable translating from hex to a color. I can imagine what a color would be, but I can't be certain, and I've been doing it a long time. I guess it could be the first 'raw' user input source in the prompt buffer.

I mean, CSS supports lots of color names. You don't need to necessarily use #HEX or rgb(35, 100, 20) to set the color. That's why CSS is a good way to go here :)

[jmercouris]

That works too :-)

[jmercouris]

Hello Artyom, I am taking a look at this now :-)

[aartaka]

Be aware that there's no toggle to turn these Nyxt dialogs on/off yet!

[jmercouris]

Hm, then I will not merge for now.

[aartaka]

And I also have a color-chooser somewhere in stashes :)

[Ambrevar]

Sorry for the delay, I'll have a look as soon as possible.

[aartaka]

OK, here's the native-dialogs switch! We can merge if it doesn't break on CI :)

Color-chooser proved to be quite complex, because getting the color of DOM element is a non-obvious task, while I need it to leverage all the power of CSS. Let's leave it for later and open an issue on it.

[aartaka]

It doesn't seem to break on CI :D

[Ambrevar]

Just tested: it seems to hang the current page when the user exits with `escape` instead of confirming the dialog. Other than that, congrats on this, it's a fantastic change :) I'll update the cl-webkit Guix package just now.

[aartaka]

All adressed! (I resorted to a suspicious ignore-errors to return nil from the cancelled prompt, but it's all smooth otherwise.)

[aartaka]

The last suspicious thing (the ignore-erros) is addressed in 25dbdc5. Should be mergeable, I believe.

[jmercouris]

Thanks Artyom!