Add proper typing to all slots that encode time intervals in seconds. #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adhere to new slot style when required. Review all time-related docstrings.
Ambrevar
reviewed
Nov 1, 2022
| :documentation "Execute the first of `selection-actions' after this delay | ||
| when `selection-actions-enabled-p' is non-nil.")) | ||
| :type alex:non-negative-real | ||
| :documentation "Time in seconds after which `selection-actions' run.")) |
There was a problem hiding this comment.
Much better, but you should still mention selection-actions-enabled-p.
Ambrevar
reviewed
Nov 1, 2022
aartaka
approved these changes
Nov 1, 2022
|
Merged via 5ecd600. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adhere to new slot style when required.
Review all time-related docstrings.
Description
From #2555.
Checklist:
Everything in this checklist is required for each PR. Please do not approve a PR that does not have all of these items.
cd /path/to/nyxt/checkout git submodule add https://gitlab.common-lisp.net/nyxt/py-configparser _build/py-configparser:documentations written in the aforementioned style. (It's OK to skip the docstring for really trivial parts.)changelog.lispwith my changes if it's anything user-facing (new features, important bug fix, compatibility breakage).migration.lispentry for all compatibility-breaking changes.