-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review handling of proportional and monospace fonts #3308
Conversation
I didn't make this change because it changed A LOT of the UI, including the describe interface. I'll look at it closely. |
I tested this, and interestingly enough, now noto sans was being set in the status buffer. I have no idea why this is. This is for sure not the solution! |
Is there a font (technically it couldn't be called a single font) that delivers both proportional and monospaced versions? |
I have an idea why (didn't check). We sometimes place |
I do believe that there exists a monospaced version of public sans. |
On second search I've been unable to find a reference to monospace version of Public Sans. |
Yes there is. However, I haven't really liked how they look. I have found that Bitstream Vera Sans works really well with Public Sans. I'll submit a pull request. |
This suggestion of mine is completely unrelated.
Actually, this is not related to this PR or the reported issue. Public Sans wasn't set for the status buffer from the moment when it was first developed. |
I've refactored this PR, and I still think it's superior to #3313. The addition of Public Sans brought a distinctive proportional font for our interfaces. The issue we're trying to solve is that our interfaces can't prevent the renderer from using monospaced fonts for elements that use those by default (such as Commit e399b7f is justified by the fact that we currently don't make use of font-weight other than 400 or 700 (regular and bold, respectively) and are unlikely to do so in the future. |
@jmercouris should be ready to be merged. |
I'll merge this on Monday morning the latest to make sure that it lands on the next release. |
I've added a commit that addresses the size of the prompt buffer fonts. I didn't want to force push on you, so feel free to include it however you like in the commit history. This is important for making things look reasonably sized. |
Use the fonts specifies by the theme library for buffer, panel buffer, status buffer, message buffer and prompt buffer.
It inherits from #suggestions.
For suggestions and suggestion/mark count.
Accommodates for the new fonts.
I've set the value of 14px for monospace and proportional fonts in a more succinct way for the prompt buffer. You've missed another instance of suggestion/mark count that should use monospaced fonts and I've fixed it. Note that the reason why I have set initially 16px/14px for proportional/monospace in the prompt buffer is because that's what you did for all other buffer UIs (in #3313). |
Closes #3307.
Closes #3314.
Closes #3315.