Review meta project facilities #3316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aadcg
force-pushed
the
review-asd-nasdf-ci
branch
3 times, most recently
from
476bfe5 to
00169a4
Compare
aadcg
force-pushed
the
review-asd-nasdf-ci
branch
from
00169a4 to
1cd3dbe
Compare
aadcg
force-pushed
the
review-asd-nasdf-ci
branch
from
1cd3dbe to
ed8f841
Compare
Its goal is to report unbound exports and undocumented exported symbols. The implementation is lacking and these kind of linters are easily replaceable with stronger programmer discipline.
It's the CI that needs to adapt to development spirit of CL, not the other way around. Therefore, env var NASDF_TESTS_QUIT_ON_FAIL and nasdf:fail-on-warnings aren't needed. Have nasdf-test-system inherit from nasdf-system.
When writing .asd files, symbols from packages asdf and uiop are available and it is bad taste to use package prefixed symbols such as asdf:foo or uiop:bar. Since NASDF is an extension of ASDF, the change is justified.
The tests are broken; the testing strategy is sub-par and the tested invariants are rather uninteresting.
nasdf:print-benchmark doesn't belong to NASDF, but rather to https://github.com/Shinmera/trivial-benchmark/. Rename system from nyxt/benchmark to nyxt/benchmarks to mimic nyxt/tests. The only benchmark written is rather uninteresting, but it serves as a proof of concept for future endeavors.
renderer/gtk-clipboard is deleted since the functionality has been deleted in commit 57b6ebe. cl-webkit2 depends on cl-cffi-gtk.
nyxt/gtk depends on bordeaux-threads.
Should have been part of commit 9d10d0c.
search-buffer-mode no longer depends on hint-mode.
Run tests on SBCL exclusively. With the deprecation of NASDF_TESTS_QUIT_ON_FAIL, the CI must handle the fact that a failing test return the appropriate exiting code.
Added in commit 91ecf06. The mode has been deleted.
It is not used in any of the official distributions means and it is unlikely to be ever turned on.
The official distribution means and dev env don't rely on Quicklisp.
Nyxt only supports SBCL. The makefile still allows developers to attempt supporting other CL implementations. Delete references to quicklisp since both the official distribution means and dev env don't rely on it.
Broken functionality.
aadcg
force-pushed
the
review-asd-nasdf-ci
branch
from
ed8f841 to
4d4e459
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A revision of
nyxt.asd, NASDF, CI,INSTALL, etc.Checklist:
(asdf:test-system :nyxt/gi-gtk))