Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common settings keybindings review #3326

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Common settings keybindings review #3326

merged 3 commits into from
Jan 30, 2024

Conversation

aadcg
Copy link
Member

@aadcg aadcg commented Jan 29, 2024 •
edited
Loading

Description

Given #3321, these minor changes may help users manage their expectations from the interface.

Checklist:

  • Git branch state is mergable.
  • Changelog is up to date (via a separate commit).
  • New dependencies are accounted for.
  • Documentation is up to date.
  • Compilation and tests ((asdf:test-system :nyxt/gi-gtk))
    • No new compilation warnings.
    • Tests are sufficient.

@aadcg aadcg requested a review from jmercouris January 29, 2024 20:36
@aadcg aadcg force-pushed the common-settings-keybindings-review branch from 31cb237 to 3a93d0c Compare January 30, 2024 19:54
@aadcg aadcg merged commit 8a52e4a into master Jan 30, 2024
1 check passed
@aadcg aadcg deleted the common-settings-keybindings-review branch January 30, 2024 19:55
@aadcg aadcg mentioned this pull request Jan 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmercouris jmercouris Awaiting requested review from jmercouris

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aadcg