Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nyxt scheme callback logic #3421

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Fix nyxt scheme callback logic #3421

merged 4 commits into from
Jun 20, 2024

Conversation

aadcg
Copy link
Member

@aadcg aadcg commented Jun 20, 2024 •
edited
Loading

Description

Checklist:

  • Git branch state is mergable.
  • Changelog is up to date (via a separate commit).
  • New dependencies are accounted for.
  • Documentation is up to date.
  • Compilation and tests ((asdf:test-system :nyxt/<renderer>))
    • No new compilation warnings.
    • Tests are sufficient.

aadcg added 4 commits June 20, 2024 22:18
@aadcg
urls: Fix nyxt scheme callback logic.
41f6199 
The wrangling that ensures that find-internal-page-buffer returns non-nil is
rather clumsy and shows that the design is subpar.  Right now, it would
be unwise to engage in a deeper refactor.

Closes #3417.
@aadcg
renderer-script(find-url-internal-page): Minor refactor.
b207e35
@aadcg
panel(find-panel-buffer): Minor refactor.
e9413e5
@aadcg
help(new): Refactor link buttons.
235a36d 
Use the nbutton construct for all cases.

Open the links in new buffers.

Review mouseover text.
@aadcg aadcg merged commit f93c945 into master Jun 20, 2024
3 checks passed
@aadcg aadcg deleted the fix-3417 branch June 20, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aadcg