Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3: Include stack traces for napi threadsafe functions #101

Closed
wants to merge 4 commits into from
Closed

V3: Include stack traces for napi threadsafe functions #101

wants to merge 4 commits into from

Conversation

alshdavid
Copy link
Contributor

This adds stack traces to error thrown in Napi threadsafe functions

I will use better types when we move to TypeScript

This requires that the Rust JsCallable is paired with the JavaScript JsCallable

const reportError = jsCallable(() => {
  throw new Error('Hello World')
})

alshdavid
alshdavid commented Oct 1, 2024
View reviewed changes
crates/atlaspack_napi_helpers/src/js_callable/js_callable.rs
Params: Serialize + Send + Sync + 'static,
{
self.call(map_params_serde(params))
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were not using this and it has footguns so I thought it was best to remove it

@alshdavid
Copy link
Contributor Author

I'll come back to this later

@alshdavid alshdavid closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamadapc yamadapc yamadapc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alshdavid @yamadapc