Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always run all V2 tests #78

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
8 changes: 4 additions & 4 deletions crates/atlaspack_plugin_rpc/src/plugin/resolver.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
use std::fmt;
use std::fmt::Debug;

use anyhow::anyhow;
use atlaspack_config::PluginNode;
use atlaspack_core::plugin::PluginContext;
use atlaspack_core::plugin::ResolveContext;
use atlaspack_core::plugin::Resolved;
use atlaspack_core::plugin::ResolverPlugin;
use std::fmt;
use std::fmt::Debug;

#[derive(Hash)]
pub struct RpcResolverPlugin {}
Expand All @@ -24,6 +24,6 @@ impl RpcResolverPlugin {

impl ResolverPlugin for RpcResolverPlugin {
fn resolve(&self, _ctx: ResolveContext) -> Result<Resolved, anyhow::Error> {
todo!()
Err(anyhow!("Not implemented"))
}
}
4 changes: 3 additions & 1 deletion packages/core/core/src/requests/BundleGraphRequest.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@ export default function createBundleGraphRequest(
let {assetGraph, changedAssets, assetRequests} = await api.runRequest(
request,
{
force: options.shouldBuildLazily && requestedAssetIds.size > 0,
force:
Boolean(input.rustAtlaspack) ||
(options.shouldBuildLazily && requestedAssetIds.size > 0),
},
);

Expand Down
4 changes: 2 additions & 2 deletions packages/core/integration-tests/test/BundleGraph.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
} from '@atlaspack/test-utils';
import type {BundleGraph, BundleGroup, PackagedBundle} from '@atlaspack/types';

describe.v2('BundleGraph', () => {
describe('BundleGraph', () => {
it('can traverse assets across bundles and contexts', async () => {
let b = await bundle(
path.join(__dirname, '/integration/worker-shared/index.js'),
Expand Down Expand Up @@ -85,7 +85,7 @@ describe.v2('BundleGraph', () => {
]);
});

describe('getBundlesInBundleGroup', () => {
describe.v2('getBundlesInBundleGroup', () => {
let bundleGraph: BundleGraph<PackagedBundle>;
let bundleGroup: BundleGroup;
let dir = path.join(__dirname, 'get-bundles-in-bundle-group');
Expand Down
4 changes: 2 additions & 2 deletions packages/core/integration-tests/test/api.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ import {

import {ATLASPACK_VERSION} from '../../core/src/constants';

describe.v2('JS API', function () {
it('should respect distEntry', async function () {
describe('JS API', function () {
it.v2('should respect distEntry', async function () {
const NAME = 'custom-name.js';

let b = await bundle(
Expand Down
Loading
Loading