return empty response when subscription are running on the internal introspection service #649
Conversation
…ntrospection service
| "locations": [], | ||
| "message": "null", | ||
| "extensions": { | ||
| "classification": "ValidationError" |
There was a problem hiding this comment.
this error is coming from a "remove field" transform that we use for tests. I activated this transform with onCommentUpdated(id: ID): Comment @toBeDeleted directive in the overall schema
There was a problem hiding this comment.
previously we would blow up with your data fetcher must return a publisher ... kind of an error
| @@ -40,6 +41,9 @@ open class NadelDefaultIntrospectionRunner(schema: GraphQLSchema) : ServiceExecu | |||
| .build() | |||
|
|
|||
| override fun execute(serviceExecutionParameters: ServiceExecutionParameters): CompletableFuture<ServiceExecutionResult> { | |||
| if (serviceExecutionParameters.operationDefinition.operation == OperationDefinition.Operation.SUBSCRIPTION) { | |||
| return CompletableFuture.completedFuture(NadelServiceExecutionResultImpl()) | |||
| "locations": [], | ||
| "message": "null", | ||
| "extensions": { | ||
| "classification": "ValidationError" |
There was a problem hiding this comment.
So this is an error from the introspection service? Why is the error message null?
There was a problem hiding this comment.
nah, this error is coming from the transform, look at this comment https://github.com/atlassian-labs/nadel/pull/649/files/5774cd1580b7dcaeaecb6b6b7d46bdea52b078eb#r1870548215
There was a problem hiding this comment.
I clarified the error message on the RemoveFieldTransform to make it less confusing
temaEmelyan
dismissed stale reviews from bbakerman and russellyou
via
1213053
…nternal-introspection-service
Please make sure you consider the following: