Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix index error when multiple selections were dragged to the original position #2661

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: fix index error when multiple selections were dragged to the original position #2661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion stories/src/multi-drag/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,13 @@ const reorderMultiDrag = ({

const index: number = column.taskIds.indexOf(current);

if (index >= destination.index) {
// When dragging up, do not increment the indexOffset while source.index equal to destination.index.
// When dragging down, increment the indexOffset while source.index equal to destination.index
if (
source.index >= destination.index
? index >= destination.index
: index > destination.index
) {
return previous;
}

Expand Down