-
Notifications
You must be signed in to change notification settings - Fork 24
Prereqs for validating service instance #244
Conversation
cmd/smith/app/app.go
Outdated
@@ -117,6 +118,10 @@ func (a *App) Run(ctx context.Context) error { | |||
if err != nil { | |||
return err | |||
} | |||
var catalogger *catalog.Catalog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really unhappy with the naming for this one, but I'm not sure what it should be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, var catalogClient *catalog.Client is go ish?
Scaffolding (informers) set up, no actual validation yet.
a8ff1d9
to
7a84366
Compare
ExternalID: servicePlanName, | ||
}, | ||
}, | ||
}...)..., |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more dots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah... this was a bit silly. I was a little bit too keen to write it as one expression, I guess.
I think I've addressed what we talked about @ash2k , but I probably missed something... |
9cde6f4
to
95d8016
Compare
95d8016
to
136fc0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Scaffolding (informers) set up, no actual validation yet. Smaller PRs?
Part of #187