This repository has been archived by the owner on Jan 13, 2021. It is now read-only.
Prereqs for validating service instance #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wryun
commented
Feb 13, 2018
cmd/smith/app/app.go
Outdated
| @@ -117,6 +118,10 @@ func (a *App) Run(ctx context.Context) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| var catalogger *catalog.Catalog | |||
There was a problem hiding this comment.
I'm really unhappy with the naming for this one, but I'm not sure what it should be.
There was a problem hiding this comment.
hmm, var catalogClient *catalog.Client is go ish?
Scaffolding (informers) set up, no actual validation yet.
wryun
force-pushed
the
187-validate-service-instance
branch
from
a8ff1d9
to
7a84366
Compare
amckague
reviewed
Feb 14, 2018
| ExternalID: servicePlanName, | ||
| }, | ||
| }, | ||
| }...)..., |
There was a problem hiding this comment.
yeah... this was a bit silly. I was a little bit too keen to write it as one expression, I guess.
amckague
approved these changes
Feb 14, 2018
|
I think I've addressed what we talked about @ash2k , but I probably missed something... |
wryun
force-pushed
the
187-validate-service-instance
branch
from
9cde6f4
to
95d8016
Compare
wryun
force-pushed
the
187-validate-service-instance
branch
from
95d8016
to
136fc0a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scaffolding (informers) set up, no actual validation yet. Smaller PRs?
Part of #187