Preview most recent version of images #53
Conversation
This is a WIP towards #49
|
Still needs specs and currently doesn't condition on local or remote images (and I don't know how pathwatcher responds to remote images) |
|
what is the refresh condition? pathwatch tells you that the file changed? |
| # Use most recent version of image | ||
| if imgVersion[src]? | ||
| if imgVersion[src] > 0 | ||
| src = "#{src}##{imgVersion[src]}" |
There was a problem hiding this comment.
I would like "#{src}?v=#{imgVersion[src]}" more 👍
Exactly that. Pathwatcher will watch for any changes on the file, and then increment the The debounce is to cover multiple fires as described in atom/node-pathwatcher#50. |
Also if an image was previewed and subsequently deleted the version query takes the value `deleted`.
|
All specs are passing, and I think the specs I added for this PR give good coverage. I'll review tomorrow with fresher eye's and if everything's still looking good I'll merge in to master :D |
|
Looks really nice, especially your test png 💃 👍 |
|
@leipert Thanks for the eye's on :D |
This is a WIP towards #49