This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Added option to enable
pcre2
ripgrep regex engine, as discussed in here.NOTE: I haven't written any specs because I'm not sure what steps to take. Should I wrap all the specs in additional loop, same as prev PR has done with ripgrep support?
NOTE: cannot build Atom ATM so haven't tested the changes locally.
Benefits
Allows additional regex features such as lookbehind.
Possible Drawbacks
Enabling PCRE2 potentially incurs performance penalty, as explained on ripgrep's wiki, thus this PR does not enable it by default, and instead adds an option.
Applicable Issues
Addresses #571
Accompanying PR in atom core